Skip to content

fs: add v8 fast api to closeSync - #53627

Merged
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
anonrig:add-fast-api-for-close
Jul 15, 2024
Merged

fs: add v8 fast api to closeSync#53627
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
anonrig:add-fast-api-for-close

Conversation

@anonrig

@anonriganonrig commented Jun 28, 2024

Copy link
Copy Markdown
Member

Adds V8 Fast API to fs.closeSync(fd) implementation

cc @nodejs/performance @nodejs/fs @nodejs/cpp-reviewers

@anonrig
anonrig requested a review from tniessenJune 28, 2024 14:58
@nodejs-github-botnodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. fs Issues and PRs related to the fs subsystem / file system. needs-ci PRs that need a full CI run. labels Jun 28, 2024
@anonrig
anonrigforce-pushed the add-fast-api-for-close branch from 3d363dc to 734d1baCompareJune 28, 2024 15:00
H4ad
H4ad reviewed Jun 28, 2024
View reviewed changes
Comment threadsrc/node_file.cc Outdated
H4ad
H4ad reviewed Jun 28, 2024
View reviewed changes
Comment threadsrc/node_file.cc Outdated
H4ad
H4ad reviewed Jun 28, 2024
View reviewed changes
Comment threadsrc/node_file.cc Outdated
@anonrig
anonrigforce-pushed the add-fast-api-for-close branch from 734d1ba to 8354379CompareJune 28, 2024 15:39
tniessen
tniessen reviewed Jun 28, 2024
View reviewed changes
Comment threadsrc/node_external_reference.h Outdated
mcollina
mcollina approved these changes Jun 28, 2024
View reviewed changes

@mcollinamcollina left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

H4ad
H4ad reviewed Jun 28, 2024
View reviewed changes
Comment threadsrc/node_file.cc Outdated
@anonriganonrig added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels Jul 1, 2024
Qard
Qard approved these changes Jul 2, 2024
View reviewed changes
@github-actionsgithub-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jul 3, 2024
@nodejs-github-bot

nodejs-github-bot commented Jul 3, 2024

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/60040/

@nodejs-github-bot

nodejs-github-bot commented Jul 10, 2024

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/60219/

@nodejs-github-bot

nodejs-github-bot commented Jul 11, 2024

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/60253/

joyeecheung
joyeecheung reviewed Jul 11, 2024
View reviewed changes
Comment threadsrc/node_file.cc Outdated

@joyeecheungjoyeecheungJul 11, 2024•
edited
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is unsafe, RemoveUnmanagedFd() can call ProcessEmitWarning() which calls back into JS process.emitWarning() and violates the fast API protocol. Although since it's just a warning, you could probably just add a parameter to RemoveUnmanagedFd to make it invoke ProcessEmitWarning() later in a native Immediate, and scheduling a native immediate is safe.

@anonriganonrigJul 11, 2024

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If I understood you correctly, inside RemoveUnmanagedFd you want me to conditionally call the following right?

SetImmediateThreadsafe([](Environment* env) {
ProcessEmitWarning(
this, "File descriptor %d closed but not opened in unmanaged mode", fd);
});

If not, what is the correct way to schedule a native immediate?

@anonriganonrigJul 11, 2024

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I got it. Can you review it again? @joyeecheung

@anonrig
anonrigforce-pushed the add-fast-api-for-close branch from 8354379 to 7b573d1CompareJuly 11, 2024 19:34
@nodejs-github-bot

nodejs-github-bot commented Jul 11, 2024

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/60259/

@nodejs-github-bot

nodejs-github-bot commented Jul 11, 2024

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/60264/

@anonrig

anonrig commented Jul 12, 2024

Copy link
Copy Markdown
MemberAuthor

cc @nodejs/cpp-reviewers

@anonrig
anonrig requested a review from mcollinaJuly 14, 2024 23:26
@anonrig
anonrig requested review from H4ad, Qard and jasnellJuly 14, 2024 23:26
jasnell
jasnell approved these changes Jul 15, 2024
View reviewed changes
Comment threadsrc/env.cc
}

void Environment::RemoveUnmanagedFd(int fd) {
void Environment::RemoveUnmanagedFd(int fd, bool schedule_native_immediate) {

@jasnelljasnellJul 15, 2024

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not: generally not a fan of bool arguments like this. I prefer enums that allow the call sites to be clearer about what the argument is as opposed to just true or false.

@anonriganonrig added the commit-queue Add this label to land a pull request using GitHub Actions. label Jul 15, 2024
@nodejs-github-botnodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jul 15, 2024
@nodejs-github-bot
nodejs-github-bot merged commit ed6f45b into nodejs:mainJul 15, 2024
@nodejs-github-bot

nodejs-github-bot commented Jul 15, 2024

Copy link
Copy Markdown
Collaborator

Landed in ed6f45b

aduh95 pushed a commit that referenced this pull request Jul 16, 2024
@anonrig@aduh95
fs: add v8 fast api to closeSync
8368555
PR-URL: #53627
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Vinícius Lourenço Claro Cardoso <contact@viniciusl.com.br>
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@aduh95aduh95 mentioned this pull request Jul 16, 2024
Merged
@cjihrigcjihrig mentioned this pull request Jul 17, 2024
Closed
@merceyzmerceyz mentioned this pull request Jul 17, 2024
Closed
1 task
@avivkelleravivkeller mentioned this pull request Jul 17, 2024
Merged
@targostargos mentioned this pull request Jul 18, 2024
Closed
ehsankhfr pushed a commit to ehsankhfr/node that referenced this pull request Jul 18, 2024
@anonrig@ehsankhfr
fs: add v8 fast api to closeSync
458fe92
PR-URL: nodejs#53627
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Vinícius Lourenço Claro Cardoso <contact@viniciusl.com.br>
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@anonriganonrig mentioned this pull request Jul 18, 2024
Closed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnelljasnelljasnell approved these changes
@tniessentniessenAwaiting requested review from tniessen
@joyeecheungjoyeecheungAwaiting requested review from joyeecheung
@mcollinamcollinaAwaiting requested review from mcollina
@QardQardAwaiting requested review from Qard
@H4adH4adAwaiting requested review from H4ad

Assignees

No one assigned

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.c++Issues and PRs that require attention from people who are familiar with C++.fsIssues and PRs related to the fs subsystem / file system.needs-ciPRs that need a full CI run.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

9 participants

@anonrig@nodejs-github-bot@mcollina@Qard@jasnell@tniessen@joyeecheung@H4ad@richardlau