Skip to content

fs: move ToNamespacedPath dir calls to c++ - #53630

Merged
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
anonrig:opendir-tonamespacedpath
Jul 11, 2024
Merged

fs: move ToNamespacedPath dir calls to c++#53630
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
anonrig:opendir-tonamespacedpath

Conversation

@anonrig

@anonriganonrig commented Jun 28, 2024

Copy link
Copy Markdown
Member

Moves toNamespacedPath calls to C++ just like the rest of node:fs

@nodejs-github-botnodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. fs Issues and PRs related to the fs subsystem / file system. needs-ci PRs that need a full CI run. labels Jun 28, 2024
@anonriganonrig added the review wanted PRs that need reviews. label Jun 29, 2024
@anonrig

anonrig commented Jun 29, 2024

Copy link
Copy Markdown
MemberAuthor

cc @nodejs/url @nodejs/fs @nodejs/cpp-reviewers

@anonriganonrig added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels Jun 30, 2024
@anonriganonrig removed the review wanted PRs that need reviews. label Jul 1, 2024
@github-actionsgithub-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jul 3, 2024
@nodejs-github-bot

nodejs-github-bot commented Jul 3, 2024

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/60038/

@nodejs-github-bot

nodejs-github-bot commented Jul 10, 2024

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/60224/

@nodejs-github-bot

nodejs-github-bot commented Jul 11, 2024

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/60251/

@anonriganonrig added the commit-queue Add this label to land a pull request using GitHub Actions. label Jul 11, 2024
@nodejs-github-botnodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jul 11, 2024
@nodejs-github-bot
nodejs-github-bot merged commit 3ad2e12 into nodejs:mainJul 11, 2024
@nodejs-github-bot

nodejs-github-bot commented Jul 11, 2024

Copy link
Copy Markdown
Collaborator

Landed in 3ad2e12

aduh95 pushed a commit that referenced this pull request Jul 12, 2024
@anonrig@aduh95
fs: move ToNamespacedPath dir calls to c++
b9d9201
PR-URL: #53630
Reviewed-By: Vinícius Lourenço Claro Cardoso <contact@viniciusl.com.br>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
@aduh95aduh95 mentioned this pull request Jul 12, 2024
Merged
aduh95 pushed a commit that referenced this pull request Jul 16, 2024
@anonrig@aduh95
fs: move ToNamespacedPath dir calls to c++
076e82c
PR-URL: #53630
Reviewed-By: Vinícius Lourenço Claro Cardoso <contact@viniciusl.com.br>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
ehsankhfr pushed a commit to ehsankhfr/node that referenced this pull request Jul 18, 2024
@anonrig@ehsankhfr
fs: move ToNamespacedPath dir calls to c++
706c71c
PR-URL: nodejs#53630
Reviewed-By: Vinícius Lourenço Claro Cardoso <contact@viniciusl.com.br>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@QardQardQard approved these changes
@jasnelljasnelljasnell approved these changes
@H4adH4adH4ad approved these changes

Assignees

No one assigned

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.c++Issues and PRs that require attention from people who are familiar with C++.fsIssues and PRs related to the fs subsystem / file system.needs-ciPRs that need a full CI run.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@anonrig@nodejs-github-bot@Qard@jasnell@H4ad@targos