Skip to content

fs: reduce throwing unnecessary errors on glob - #53632

Merged
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
anonrig:glob-reduce-errors
Jul 11, 2024
Merged

fs: reduce throwing unnecessary errors on glob#53632
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
anonrig:glob-reduce-errors

Conversation

@anonrig

@anonriganonrig commented Jun 28, 2024

Copy link
Copy Markdown
Member

Removes unnecessary error thrown when lstatSync is called without throwIfNoEntry option.

@nodejs-github-botnodejs-github-bot added fs Issues and PRs related to the fs subsystem / file system. needs-ci PRs that need a full CI run. labels Jun 28, 2024
@anonriganonrig added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels Jun 28, 2024
@github-actionsgithub-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jul 3, 2024
@nodejs-github-bot

nodejs-github-bot commented Jul 3, 2024

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/60037/

@nodejs-github-bot

nodejs-github-bot commented Jul 10, 2024

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/60217/

@nodejs-github-bot

nodejs-github-bot commented Jul 11, 2024

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/60250/

@anonriganonrig added the commit-queue Add this label to land a pull request using GitHub Actions. label Jul 11, 2024
@nodejs-github-botnodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jul 11, 2024
@nodejs-github-bot
nodejs-github-bot merged commit b6ca3d7 into nodejs:mainJul 11, 2024
@nodejs-github-bot

nodejs-github-bot commented Jul 11, 2024

Copy link
Copy Markdown
Collaborator

Landed in b6ca3d7

aduh95 pushed a commit that referenced this pull request Jul 12, 2024
@anonrig@aduh95
fs: reduce throwing unnecessary errors on glob
536ea02
PR-URL: #53632
Reviewed-By: Vinícius Lourenço Claro Cardoso <contact@viniciusl.com.br>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
@aduh95aduh95 mentioned this pull request Jul 12, 2024
Merged
aduh95 pushed a commit that referenced this pull request Jul 16, 2024
@anonrig@aduh95
fs: reduce throwing unnecessary errors on glob
628a539
PR-URL: #53632
Reviewed-By: Vinícius Lourenço Claro Cardoso <contact@viniciusl.com.br>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
ehsankhfr pushed a commit to ehsankhfr/node that referenced this pull request Jul 18, 2024
@anonrig@ehsankhfr
fs: reduce throwing unnecessary errors on glob
b6bc4f5
PR-URL: nodejs#53632
Reviewed-By: Vinícius Lourenço Claro Cardoso <contact@viniciusl.com.br>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnelljasnelljasnell approved these changes
@MoLowMoLowMoLow approved these changes
@H4adH4adH4ad approved these changes
@atlowChemiatlowChemiatlowChemi approved these changes

Assignees

No one assigned

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.fsIssues and PRs related to the fs subsystem / file system.needs-ciPRs that need a full CI run.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@anonrig@nodejs-github-bot@jasnell@MoLow@H4ad@atlowChemi@targos