Uh oh!
There was an error while loading. Please reload this page.
Added OpenSSL Security Level section to docs/api/tls.md - #53647
Conversation
avivkeller
left a comment
There was a problem hiding this comment.
A few nitpicks, but this is non blocking, nor does it have the power to (because I'm not a core collaborator, but rather a issue triager)
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
pimterry
left a comment
There was a problem hiding this comment.
Echoing the couple of last small tweaks from @redyetidev, but once those are resolved this all looks good to me. Thanks for putting this together @afanasy, looks great & it'll be super helpful for others trying to use old TLS settings.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
avivkeller
commented
Jul 3, 2024
Also, the commit message of the first commit should begin with the change category/subsystem, and then the commit message starting with a present-tense verb. For example, |
afanasy
commented
Jul 9, 2024
@redyetidev@pimterry Thank you so much for the prompt review! I've made the changes you've mentioned and force-pushed to update the commit message. |
nodejs-github-bot
commented
Jul 10, 2024
Landed in 059f2f4 |
PR-URL: #53647 Reviewed-By: Tim Perry <pimterry@gmail.com>
PR-URL: #53647 Reviewed-By: Tim Perry <pimterry@gmail.com>
PR-URL: nodejs#53647 Reviewed-By: Tim Perry <pimterry@gmail.com>
@pimterry Docs update as discussed #49236.