Skip to content

Added OpenSSL Security Level section to docs/api/tls.md - #53647

Merged
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
afanasy:main
Jul 10, 2024
Merged

Added OpenSSL Security Level section to docs/api/tls.md#53647
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
afanasy:main

Conversation

@afanasy

Copy link
Copy Markdown
Contributor

@pimterry Docs update as discussed #49236.

@nodejs-github-botnodejs-github-bot added doc Issues and PRs related to the documentations. tls Issues and PRs related to the tls subsystem. labels Jun 30, 2024

@avivkelleravivkeller left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few nitpicks, but this is non blocking, nor does it have the power to (because I'm not a core collaborator, but rather a issue triager)

Comment threaddoc/api/tls.md Outdated
Comment threaddoc/api/tls.md Outdated
Comment threaddoc/api/tls.md Outdated
Comment threaddoc/api/tls.md Outdated
@avivkelleravivkeller added the openssl Issues and PRs related to the OpenSSL dependency. label Jul 1, 2024

@pimterrypimterry left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Echoing the couple of last small tweaks from @redyetidev, but once those are resolved this all looks good to me. Thanks for putting this together @afanasy, looks great & it'll be super helpful for others trying to use old TLS settings.

Comment threaddoc/api/tls.md Outdated
Comment threaddoc/api/tls.md Outdated
Comment threaddoc/api/tls.md Outdated
@avivkeller

Copy link
Copy Markdown
Member

Also, the commit message of the first commit should begin with the change category/subsystem, and then the commit message starting with a present-tense verb.

For example,
doc: add OpenSSL security level to TLS docs

@afanasy

Copy link
Copy Markdown
ContributorAuthor

@redyetidev@pimterry Thank you so much for the prompt review! I've made the changes you've mentioned and force-pushed to update the commit message.

@pimterrypimterry added the commit-queue Add this label to land a pull request using GitHub Actions. label Jul 10, 2024
@nodejs-github-botnodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jul 10, 2024
@nodejs-github-bot
nodejs-github-bot merged commit 059f2f4 into nodejs:mainJul 10, 2024
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

Landed in 059f2f4

aduh95 pushed a commit that referenced this pull request Jul 12, 2024
PR-URL: #53647
Reviewed-By: Tim Perry <pimterry@gmail.com>
@aduh95aduh95 mentioned this pull request Jul 12, 2024
aduh95 pushed a commit that referenced this pull request Jul 16, 2024
PR-URL: #53647
Reviewed-By: Tim Perry <pimterry@gmail.com>
ehsankhfr pushed a commit to ehsankhfr/node that referenced this pull request Jul 18, 2024
PR-URL: nodejs#53647
Reviewed-By: Tim Perry <pimterry@gmail.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docIssues and PRs related to the documentations.opensslIssues and PRs related to the OpenSSL dependency.tlsIssues and PRs related to the tls subsystem.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@afanasy@avivkeller@nodejs-github-bot@pimterry@marco-ippolito