Skip to content

src: move loadEnvFile toNamespacedPath call - #53658

Merged
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
anonrig:move-load-env-file-tonamespaced-path
Jul 12, 2024
Merged

src: move loadEnvFile toNamespacedPath call#53658
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
anonrig:move-load-env-file-tonamespaced-path

Conversation

@anonrig

@anonriganonrig commented Jun 30, 2024

Copy link
Copy Markdown
Member

Removes toNamespacedPath call, and moves it into C++.

@nodejs-github-botnodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. process Issues and PRs related to the process subsystem. labels Jun 30, 2024
@anonriganonrig added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels Jun 30, 2024
@github-actionsgithub-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jul 3, 2024
@nodejs-github-bot

nodejs-github-bot commented Jul 3, 2024

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/60031/

@anonriganonrig added the request-ci Add this label to start a Jenkins CI on a PR. label Jul 7, 2024
@github-actionsgithub-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jul 7, 2024
@nodejs-github-bot

nodejs-github-bot commented Jul 7, 2024

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/60128/

@nodejs-github-bot

nodejs-github-bot commented Jul 8, 2024

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/60172/

@nodejs-github-bot

nodejs-github-bot commented Jul 10, 2024

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/60216/

@nodejs-github-bot

nodejs-github-bot commented Jul 11, 2024

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/60266/

@anonriganonrig added the commit-queue Add this label to land a pull request using GitHub Actions. label Jul 12, 2024
@nodejs-github-botnodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jul 12, 2024
@nodejs-github-bot
nodejs-github-bot merged commit fc23362 into nodejs:mainJul 12, 2024
@nodejs-github-bot

nodejs-github-bot commented Jul 12, 2024

Copy link
Copy Markdown
Collaborator

Landed in fc23362

aduh95 pushed a commit that referenced this pull request Jul 12, 2024
@anonrig@aduh95
src: move loadEnvFile toNamespacedPath call
ecfde11
PR-URL: #53658
Reviewed-By: Vinícius Lourenço Claro Cardoso <contact@viniciusl.com.br>
Reviewed-By: James M Snell <jasnell@gmail.com>
@aduh95aduh95 mentioned this pull request Jul 12, 2024
Merged
aduh95 pushed a commit that referenced this pull request Jul 16, 2024
@anonrig@aduh95
src: move loadEnvFile toNamespacedPath call
d41ed44
PR-URL: #53658
Reviewed-By: Vinícius Lourenço Claro Cardoso <contact@viniciusl.com.br>
Reviewed-By: James M Snell <jasnell@gmail.com>
ehsankhfr pushed a commit to ehsankhfr/node that referenced this pull request Jul 18, 2024
@anonrig@ehsankhfr
src: move loadEnvFile toNamespacedPath call
8b189bd
PR-URL: nodejs#53658
Reviewed-By: Vinícius Lourenço Claro Cardoso <contact@viniciusl.com.br>
Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnelljasnelljasnell approved these changes
@H4adH4adH4ad approved these changes

Assignees

No one assigned

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.c++Issues and PRs that require attention from people who are familiar with C++.needs-ciPRs that need a full CI run.processIssues and PRs related to the process subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@anonrig@nodejs-github-bot@jasnell@H4ad@marco-ippolito