Skip to content

fs: improve error performance of fs.dir - #53667

Merged
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
anonrig:fs-dir-improve-error
Jul 9, 2024
Merged

fs: improve error performance of fs.dir#53667
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
anonrig:fs-dir-improve-error

Conversation

@anonrig

@anonriganonrig commented Jul 1, 2024

Copy link
Copy Markdown
Member

Reduces the C++ -> JS communication on error path by throwing the error from C++. We did the same optimization for remaining fs calls, and saw some promising results.

cc @nodejs/performance @nodejs/fs @nodejs/cpp-reviewers

@nodejs-github-botnodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. fs Issues and PRs related to the fs subsystem / file system. needs-ci PRs that need a full CI run. typings labels Jul 1, 2024
@anonriganonrig added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels Jul 1, 2024
@anonrig
anonrig requested a review from mcollinaJuly 1, 2024 17:03
mcollina
mcollina approved these changes Jul 2, 2024
View reviewed changes

@mcollinamcollina left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@github-actionsgithub-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jul 3, 2024
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot

nodejs-github-bot commented Jul 8, 2024

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/60171/

@anonriganonrig added the commit-queue Add this label to land a pull request using GitHub Actions. label Jul 9, 2024
@nodejs-github-botnodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jul 9, 2024
@nodejs-github-bot
nodejs-github-bot merged commit 307430e into nodejs:mainJul 9, 2024
@nodejs-github-bot

nodejs-github-bot commented Jul 9, 2024

Copy link
Copy Markdown
Collaborator

Landed in 307430e

aduh95 pushed a commit that referenced this pull request Jul 12, 2024
@anonrig@aduh95
fs: improve error performance of fs.dir
311f033
PR-URL: #53667
Reviewed-By: Daniel Lemire <daniel@lemire.me>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
@aduh95aduh95 mentioned this pull request Jul 12, 2024
Merged
aduh95 pushed a commit that referenced this pull request Jul 16, 2024
@anonrig@aduh95
fs: improve error performance of fs.dir
128e514
PR-URL: #53667
Reviewed-By: Daniel Lemire <daniel@lemire.me>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mcollinamcollinamcollina approved these changes
@lemirelemirelemire approved these changes
@jasnelljasnelljasnell approved these changes
@joyeecheungjoyeecheungAwaiting requested review from joyeecheung
+1 more reviewer
@VoltrexKeyvaVoltrexKeyvaVoltrexKeyva approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.c++Issues and PRs that require attention from people who are familiar with C++.fsIssues and PRs related to the fs subsystem / file system.needs-ciPRs that need a full CI run.typings

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@anonrig@nodejs-github-bot@mcollina@lemire@jasnell@VoltrexKeyva@targos