Skip to content

doc: remove incorrect scroll-padding-top offset - #53679

Closed
avivkeller wants to merge 1 commit into
nodejs:mainfrom
avivkeller:patch-65
Closed

doc: remove incorrect scroll-padding-top offset#53679
avivkeller wants to merge 1 commit into
nodejs:mainfrom
avivkeller:patch-65

Conversation

@avivkeller

Copy link
Copy Markdown
Member

Fixes#53594

This PR modifies the behavior of the docs to not begin scrolling halfway through the screen, but rather at the browser default.

Before

screen-capture.2.webm

After

screen-capture.4.webm

@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/nodejs-website

@nodejs-github-botnodejs-github-bot added the doc Issues and PRs related to the documentations. label Jul 1, 2024
@ovflowd

Copy link
Copy Markdown
Member

The title is erroneous, no?

@avivkeller

avivkeller commented Jul 2, 2024

Copy link
Copy Markdown
MemberAuthor

I don't think so, this PR updates the scrolling speed to be slower than what it was, what do you recommend for the commit?

@ovflowd

Copy link
Copy Markdown
Member

No? The title should be: "doc: removing wrong scroll padding"

@avivkeller

Copy link
Copy Markdown
MemberAuthor

Got it, thanks! I'll fix it now!

@avivkelleravivkeller changed the title doc: fix scrolling speeddoc: remove incorrect scroll-padding-top offsetJul 2, 2024
@ovflowd

Copy link
Copy Markdown
Member

I guess I understand now what that other PR was, but isn't this a duplicated PR then?

@avivkeller

avivkeller commented Jul 2, 2024

Copy link
Copy Markdown
MemberAuthor

I guess I understand now what that other PR was, but isn't this a duplicated PR then?

What other PR? The linked item is an issue. It was describing a behavior that this PR fixes, but the way they worded the behavior was a bit odd IMO.

@ovflowd

Copy link
Copy Markdown
Member

Ah interesting! I thought the same author made a PR reverting their changes that got merged back a few while ago or something like that. Too many notifications, I might be seeing things.

@jakecastelli

jakecastelli commented Jul 2, 2024

Copy link
Copy Markdown
Member

I think you might be correct about the other PR @ovflowd, do you mean this one?

kudos to both of you for looking into and fixing this annoying bug, I literally gave up on selecting text on the doc page and copied directly from the source code 😄

@avivkeller

avivkeller commented Jul 2, 2024

Copy link
Copy Markdown
MemberAuthor

Ha! I didn't see that PR, closing in favor.

Great minds think alike (and apparently time alike too)

@avivkeller
avivkeller deleted the patch-65 branch July 2, 2024 02:19
@avivkelleravivkeller added the duplicate Issues and PRs that are duplicates of other issues or PRs. label Jul 2, 2024
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docIssues and PRs related to the documentations.duplicateIssues and PRs that are duplicates of other issues or PRs.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

doc: remove scroll up when highlighting text

4 participants

@avivkeller@nodejs-github-bot@ovflowd@jakecastelli