Skip to content

deps: c-ares: cherry-pick 64df444 - #53706

Closed
zcbenz wants to merge 1 commit into
nodejs:mainfrom
zcbenz:fix-cares-win-build
Closed

deps: c-ares: cherry-pick 64df444#53706
zcbenz wants to merge 1 commit into
nodejs:mainfrom
zcbenz:fix-cares-win-build

Conversation

@zcbenz

@zcbenzzcbenz commented Jul 3, 2024

Copy link
Copy Markdown
Contributor

Backport c-ares/c-ares#802 which fixes compilation error when building for Windows with UNICODE defined.

@zcbenz
deps: c-ares: cherry-pick 64df444
b8aca0c
Backport c-ares/c-ares#802 which fixes
compilation error when building for Windows with UNICODE defined.
@nodejs-github-bot

nodejs-github-bot commented Jul 3, 2024

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/net
  • @nodejs/security-wg

@nodejs-github-botnodejs-github-bot added cares Issues and PRs related to the c-ares dependency or the cares_wrap binding. dependencies Pull requests that update a dependency file. needs-ci PRs that need a full CI run. labels Jul 3, 2024
@zcbenzzcbenz added request-ci Add this label to start a Jenkins CI on a PR. and removed cares Issues and PRs related to the c-ares dependency or the cares_wrap binding. needs-ci PRs that need a full CI run. dependencies Pull requests that update a dependency file. labels Jul 3, 2024
@github-actionsgithub-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jul 3, 2024
@nodejs-github-bot

nodejs-github-bot commented Jul 3, 2024

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/60018/

@zcbenzzcbenz added the request-ci Add this label to start a Jenkins CI on a PR. label Jul 4, 2024
@github-actionsgithub-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jul 4, 2024
@nodejs-github-bot

nodejs-github-bot commented Jul 4, 2024

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/60059/

@lpinca

lpinca commented Jul 4, 2024

Copy link
Copy Markdown
Member

A new version of c-ares is already available. I think it is better to upgrade to that version instead of cherry picking this commit.

@zcbenz

zcbenz commented Jul 4, 2024

Copy link
Copy Markdown
ContributorAuthor

I’m good updating to the latest version instead.

@lpinca

lpinca commented Jul 4, 2024

Copy link
Copy Markdown
Member

See #53722.

@zcbenzzcbenz closed this Jul 5, 2024
@zcbenz
zcbenz deleted the fix-cares-win-build branch July 5, 2024 00:30
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnelljasnelljasnell approved these changes
@StefanStojanovicStefanStojanovicStefanStojanovic approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@zcbenz@nodejs-github-bot@lpinca@jasnell@StefanStojanovic