http: expose websocket in nodehttp by anfibiacreativa · Pull Request #53721 · nodejs/node

anfibiacreativa · 2024-07-04T13:12:44Z

This PR exposes Websocket in node:http as requested in #53684
Once we discuss, if it satisfies the requirement, we can backport to Node.js 20 and 22

CC: @mcollina @nodejs/http @manekinekko

nodejs-github-bot · 2024-07-04T13:12:48Z

Review requested:

@nodejs/http
@nodejs/net

mcollina

Good job! Docs are missing too.

Can you add a test that the given objects are the same of the global?

avivkeller · 2024-07-04T16:53:30Z

Once we discuss, if it satisfies the requirement, we can backport to Node.js 20 and 22

I've added lts-watch-v20.x to the PR, as it may need to be backported to v20, but feel free to remove the label if you disagree.

Co-authored-by: Aviv Keller <38299977+RedYetiDev@users.noreply.github.com>

avivkeller

Looks good, just needs some documentation, but from (mostly, except minor changes) here-on-out, I'll leave the reviewing to collaborators.

PuruVJ · 2024-07-05T05:51:19Z

Thank you @anfibiacreativa for implementing this so darn fast! 🚀🙏

manekinekko · 2024-07-05T08:46:57Z

As discussed in #53684, can we track this change to be backported to v22.x as well?

anfibiacreativa · 2024-07-05T09:01:17Z

As discussed in #53684, can we track this change to be backported to v22.x as well?

Yes, @mcollina should we do the backporting in the same PR?

avivkeller · 2024-07-05T12:29:01Z

As discussed in #53684, can we track this change to be backported to v22.x as well?

Once this lands, backport-requested-... labels can be added if needed.

There's no LTS watch label for v22.x yet.

mcollina · 2024-07-05T13:21:37Z

As discussed in #53684, can we track this change to be backported to v22.x as well?

This will be released in v22 first, then backported to v20.x after at least two weeks.

lpinca · 2024-07-05T14:42:00Z

It may be the most appropriate module, but why http? WebSocket is a different protocol and the implementation uses undici under the hood which shares very little/no code with the Node.js http module.

We don't expose fetch, Request, Response, etc. in the http module.

avivkeller · 2024-07-05T15:17:18Z

What would you recommend exposing it under (if it were to be exposed at all), net?

lpinca · 2024-07-05T15:24:28Z

What would you recommend exposing it under (if it were to be exposed at all), net?

Just like other new globals I would not backport it. Anyway, that is my personal opinion, not a blocker.

nodejs-github-bot · 2024-07-08T15:55:44Z

Landed in a1869fa

manekinekko · 2024-07-08T19:25:25Z

Congrats @anfibiacreativa on your 1st contribution to node core!

Thank you all for taking the time to review these changes.

PR-URL: #53721 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Paolo Insogna <paolo@cowtech.it> Reviewed-By: James M Snell <jasnell@gmail.com>

Notable changes: http: * (SEMVER-MINOR) expose websockets (Natalia Venditto) #53721 module: * add __esModule to require()'d ESM (Joyee Cheung) #52166 path: * (SEMVER-MINOR) add `matchGlob` method (Aviv Keller) #52881 process: * (SEMVER-MINOR) port on-exit-leak-free to core (Vinicius Lourenço) #53239 stream: * (SEMVER-MINOR) pipeline wait for close before calling the callback (jakecastelli) #53462 worker: * (SEMVER-MINOR) add postMessageToThread (Paolo Insogna) #53682 PR-URL: #53826

PR-URL: #53721 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Paolo Insogna <paolo@cowtech.it> Reviewed-By: James M Snell <jasnell@gmail.com>

Notable changes: http: * (SEMVER-MINOR) expose websockets (Natalia Venditto) #53721 lib: * (SEMVER-MINOR) add `node:sqlite` module (Colin Ihrig) #53752 module: * add `__esModule` to `require()`'d ESM (Joyee Cheung) #52166 path: * (SEMVER-MINOR) add `matchesGlob` method (Aviv Keller) #52881 process: * (SEMVER-MINOR) port on-exit-leak-free to core (Vinicius Lourenço) #53239 stream: * (SEMVER-MINOR) pipeline wait for close before calling the callback (jakecastelli) #53462 test_runner: * support glob matching coverage files (Aviv Keller) #53553 worker: * (SEMVER-MINOR) add `postMessageToThread` (Paolo Insogna) #53682 PR-URL: #53826

Notable changes: http: * (SEMVER-MINOR) expose websockets (Natalia Venditto) nodejs#53721 lib: * (SEMVER-MINOR) add `node:sqlite` module (Colin Ihrig) nodejs#53752 module: * add `__esModule` to `require()`'d ESM (Joyee Cheung) nodejs#52166 path: * (SEMVER-MINOR) add `matchesGlob` method (Aviv Keller) nodejs#52881 process: * (SEMVER-MINOR) port on-exit-leak-free to core (Vinicius Lourenço) nodejs#53239 stream: * (SEMVER-MINOR) pipeline wait for close before calling the callback (jakecastelli) nodejs#53462 test_runner: * support glob matching coverage files (Aviv Keller) nodejs#53553 worker: * (SEMVER-MINOR) add `postMessageToThread` (Paolo Insogna) nodejs#53682 PR-URL: nodejs#53826

MTyson · 2024-07-20T21:47:12Z

Is there any info on this yet? It looks like, based on the code, that it is just exposing undici lib and that is just a client, not a server?

mcollina · 2024-07-21T07:15:42Z

This will be released in the next version of Node v22.

We don't plan to add a server.

mcollina · 2024-08-22T02:52:28Z

@marco-ippolito @nodejs/releasers I saw this was not picked up by the latest 20.17. How can we make sure it's picked up in the next one?

marco-ippolito · 2024-08-22T05:34:56Z

@marco-ippolito @nodejs/releasers I saw this was not picked up by the latest 20.17. How can we make sure it's picked up in the next one?

Yes, I was unsure because we didnt unflag websocket client on v20

mcollina · 2024-08-22T16:03:45Z

The whole point of this is exposing the Websocket client in v20. It's written in the linked issue.

Can you make sure it's in the next one?

KhafraDev · 2024-08-22T16:36:32Z

WebSocket can be exposed in node v20 (at least in 20.17.0) with --experimental-websocket as a global

targos · 2024-09-21T11:22:52Z

This lands cleanly on v20.x-staging but the test doesn't pass:

It needs --experimental-websocket
Even with the flag, assert.strictEqual(NodeHttpMessageEvent, MessageEvent); fails because the global MessageEvent in v20.x is not the undici one.

anfibiacreativa added 2 commits July 4, 2024 14:55

http: expose websockets
4083955

test: add test for exposing websocket in http
9dd678b

nodejs-github-bot added http Issues or PRs related to the http subsystem. needs-ci PRs that need a full CI run. labels Jul 4, 2024

mcollina reviewed Jul 4, 2024
View reviewed changes

Comment threadlib/http.js Outdated

richardlau added the semver-minor PRs that contain new features and should be released in the next minor version. label Jul 4, 2024

anfibiacreativa added 2 commits July 4, 2024 17:43

http: add dynamic loading on first usage
a2e4f84

test: extend test to compare strict with global
0d5d120

avivkeller added the lts-watch-v20.x label Jul 4, 2024

avivkeller reviewed Jul 4, 2024
View reviewed changes

Comment threadtest/parallel/test-http-import-websocket.js Outdated
Comment threadlib/http.js
Comment threadlib/http.js

anfibiacreativaand others added 3 commits July 4, 2024 21:06

http: refactor to lazyload classes more effectively
e4b6558

test: update test/parallel/test-http-import-websocket.js
576bdb0
Co-authored-by: Aviv Keller <38299977+RedYetiDev@users.noreply.github.com>

http: refactor lazy loading function
ecfd5ec

avivkeller approved these changes Jul 4, 2024
View reviewed changes

avivkeller self-requested a review July 4, 2024 21:21

avivkeller reviewed Jul 4, 2024
View reviewed changes

avivkeller added the commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. label Jul 5, 2024

docs: add websocket reference to http doc
9b65b5b

fix: fix linting errors from ci
804276c

avivkeller reviewed Jul 5, 2024
View reviewed changes

Comment threadtest/parallel/test-http-import-websocket.js

nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jul 8, 2024

nodejs-github-bot merged commit a1869fa into nodejs:mainJul 8, 2024

avivkeller added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. and removed request-ci-failed An error occurred while starting CI via request-ci label, and manual interventon is needed. labels Jul 8, 2024

aduh95 pushed a commit that referenced this pull request Jul 12, 2024
http: expose websockets
ec0837a
PR-URL: #53721 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Paolo Insogna <paolo@cowtech.it> Reviewed-By: James M Snell <jasnell@gmail.com>

aduh95 mentioned this pull request Jul 12, 2024
V22.5.0 proposal #53826
Merged

aduh95 pushed a commit that referenced this pull request Jul 16, 2024
http: expose websockets
1367c55
PR-URL: #53721 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Paolo Insogna <paolo@cowtech.it> Reviewed-By: James M Snell <jasnell@gmail.com>

avivkeller mentioned this pull request Sep 13, 2024
Native WebSockets in node 20 #53684
Closed

targos added the backport-requested-v20.x label Sep 30, 2024

marco-ippolito removed the lts-watch-v20.x label Jun 5, 2025

This was referenced Jul 1, 2026
feat(platform): expand SEIS Agency Kit and Apple readiness foundation emirhankudun-ux/SEIS#125
Open
Feat/ws server Rashmi7205/livescore#3
Merged

bolshoytoster mentioned this pull request Jul 16, 2026
Could undici be optional/imported lazily? cheeriojs/cheerio#5354
Open

Uh oh!

Uh oh!

Conversation

anfibiacreativa commented Jul 4, 2024

Uh oh!

nodejs-github-bot commented Jul 4, 2024

Uh oh!

mcollina left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

avivkeller commented Jul 4, 2024

Uh oh!

Uh oh!

Uh oh!

Uh oh!

avivkeller left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

PuruVJ commented Jul 5, 2024

Uh oh!

manekinekko commented Jul 5, 2024

Uh oh!

anfibiacreativa commented Jul 5, 2024

Uh oh!

avivkeller commented Jul 5, 2024

Uh oh!

mcollina commented Jul 5, 2024

Uh oh!

lpinca commented Jul 5, 2024• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

avivkeller commented Jul 5, 2024

Uh oh!

Uh oh!

lpinca commented Jul 5, 2024• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

nodejs-github-bot commented Jul 8, 2024

Uh oh!

manekinekko commented Jul 8, 2024

Uh oh!

MTyson commented Jul 20, 2024

Uh oh!

mcollina commented Jul 21, 2024

Uh oh!

mcollina commented Aug 22, 2024

Uh oh!

marco-ippolito commented Aug 22, 2024

Uh oh!

mcollina commented Aug 22, 2024

Uh oh!

KhafraDev commented Aug 22, 2024

Uh oh!

targos commented Sep 21, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

14 participants

avivkeller left a comment •
edited
Loading

lpinca commented Jul 5, 2024•
edited
Loading

lpinca commented Jul 5, 2024•
edited
Loading