Uh oh!
There was an error while loading. Please reload this page.
deps: fix include_dirs of nbytes - #53862
Merged
Merged
Conversation
nodejs-github-bot
commented
Jul 16, 2024
Collaborator
Review requested:
|
anonrig
approved these changes
Jul 16, 2024
gengjiawen
approved these changes
Jul 16, 2024
jasnell
approved these changes
Jul 16, 2024
lpinca
approved these changes
Jul 16, 2024
nodejs-github-bot
commented
Jul 18, 2024
Collaborator
nodejs-github-bot
commented
Jul 18, 2024
Collaborator
nodejs-github-bot
commented
Jul 18, 2024
Collaborator
Landed in 014dad5 |
ehsankhfr pushed a commit
to ehsankhfr/node
that referenced
this pull request
Jul 18, 2024
PR-URL: nodejs#53862 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
targos pushed a commit
that referenced
this pull request
Jul 28, 2024
PR-URL: #53862 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Set correct include dirs for both GYP and GN builds.