Uh oh!
There was an error while loading. Please reload this page.
src: refactor webstorage implementation - #53876
Merged
Merged
Conversation
anonrigforce-pushed
the
refactor-webstorage
branch
from
July 16, 2024 20:49
8af37ce to
bb81c4eComparecjihrig
approved these changes
Jul 16, 2024
cjihrig
left a comment
Contributor
There was a problem hiding this comment.
I'm not sure if the tests will pass with these changes, but LGTM if they do pass.
nodejs-github-bot
commented
Jul 16, 2024
Collaborator
cjihrig
commented
Jul 16, 2024
Contributor
As I suspected, the tests appear to be failing. The inputs to these APIs do not need to be strings, but must be able to be converted to strings. |
anonrig
commented
Jul 16, 2024
MemberAuthor
TIL. So, apparently |
anonrigforce-pushed
the
refactor-webstorage
branch
from
July 16, 2024 23:11
bb81c4e to
e53f1adComparenodejs-github-bot
commented
Jul 16, 2024
Collaborator
jasnell
approved these changes
Jul 17, 2024
nodejs-github-bot
commented
Jul 17, 2024
Collaborator
nodejs-github-bot
commented
Jul 17, 2024
Collaborator
nodejs-github-bot
commented
Jul 17, 2024
Collaborator
nodejs-github-bot
commented
Jul 18, 2024
Collaborator
Landed in 05b7bf0 |
targos pushed a commit
that referenced
this pull request
Jul 28, 2024
PR-URL: #53876 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I couldn't find a good way to split them into multiple pull-requests.