fs: fix not found close creation context

[anonrig]

Referencing a similar problem fixed by @santigimeno on #51286 (comment), this PR should fix the No creation context bug for close.

The easiest way to reproduce this is via:

const fs = require('fs')
let failed;
for (let i = 0; i < 1_000_000; i++) {
failed = fs.readFile('./configure.py', (err, done) => {
// do nothing
console.log(err, done)
})
}
console.log(failed)

Fixes#53902

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/60402/

[avivkeller]

FWIW I couldn't reproduce with that snippet (unless my computer crashing counts 🤣)!

[anonrig]

@redyetidev I added a test which fails on macOS. If you have a hard limit on "number of open files" in environments like windows, it would throw an error, but the goal is to crash, not not to have errors.

[avivkeller]

Thanks for adding the test :-)

[avivkeller]

For the rare chance that test-fs-close is moved for some reason.

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/60406/

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/60407/

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/60421/

[richardlau]

This looks related?

https://ci.nodejs.org/job/node-test-commit-arm-debug/13783/nodes=ubuntu2004_debug-arm64/consoleFull

15:42:00 not ok 1374 parallel/test-fs-close-fast-api15:42:00 ---15:42:00 duration_ms: 8968.0910015:42:00 severity: crashed15:42:00 exitcode: -615:42:00 stack: |-15:42:00 undefined15:42:00 FATAL ERROR: v8::HandleScope::CreateHandle() Cannot create a handle without a HandleScope15:42:00 ----- Native stack trace -----15:42:00 15:42:00 1: 0xaaaab4399ce4 node::DumpNativeBacktrace(_IO_FILE*) [out/Debug/node]15:42:00 2: 0xaaaab44e5018 node::OnFatalError(char const*, char const*) [out/Debug/node]15:42:00 3: 0xaaaab4950dc0 v8::Utils::ReportApiFailure(char const*, char const*) [out/Debug/node]15:42:00 4: 0xaaaab4cfd02c v8::internal::HandleScope::Extend(v8::internal::Isolate*) [out/Debug/node]15:42:00 5: 0xaaaab49412d0 v8::internal::HandleScope::CreateHandle(v8::internal::Isolate*, unsigned long) [out/Debug/node]15:42:00 6: 0xaaaab4990120 v8::Object::GetCreationContext() [out/Debug/node]15:42:00 7: 0xaaaab49901b0 v8::Object::GetCreationContextChecked() [out/Debug/node]15:42:00 8: 0xaaaab44f3a9c [out/Debug/node]15:42:00 9: 0xffff98069f10 15:42:00 ...

[anonrig]

@santigimeno@joyeecheung can you take a look?

[avivkeller]

For reference,

npm error Exit handler never called!
npm error This is an error with npm itself. Please report this error at:
npm error <https://github.com/npm/cli/issues>

still occurs on this PR (at least from my testing).