Skip to content

doc: fix worker threadId/destination typo - #53933

Merged
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
tlhunter:tlhunter/worker-threadid-docs-typo
Aug 2, 2024
Merged

doc: fix worker threadId/destination typo#53933
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
tlhunter:tlhunter/worker-threadid-docs-typo

Conversation

@tlhunter

@tlhuntertlhunter commented Jul 18, 2024

Copy link
Copy Markdown
Contributor

The function signature uses threadId instead of destination:

worker.postMessageToThread(threadId, value[, transferList][, timeout])

@nodejs-github-botnodejs-github-bot added doc Issues and PRs related to the documentations. worker Issues and PRs related to Worker support. labels Jul 18, 2024
@tlhunter
tlhunterforce-pushed the tlhunter/worker-threadid-docs-typo branch from 701a240 to c280eedCompareJuly 18, 2024 21:21
@tlhuntertlhunter changed the title docs: fix worker threadId/destination typodoc: fix worker threadId/destination typoJul 18, 2024
@jakecastellijakecastelli added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue Add this label to land a pull request using GitHub Actions. labels Jul 26, 2024
@nodejs-github-botnodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Aug 2, 2024
@nodejs-github-bot
nodejs-github-bot merged commit 13ca021 into nodejs:mainAug 2, 2024
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

Landed in 13ca021

@tlhunter
tlhunter deleted the tlhunter/worker-threadid-docs-typo branch August 2, 2024 13:40
targos pushed a commit that referenced this pull request Aug 14, 2024
PR-URL: #53933
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Jake Yuesong Li <jake.yuesong@gmail.com>
@RafaelGSSRafaelGSS mentioned this pull request Aug 19, 2024
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.docIssues and PRs related to the documentations.workerIssues and PRs related to Worker support.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants

@tlhunter@nodejs-github-bot@jasnell@lpinca@aymen94@jakecastelli@targos