Skip to content

src: switch from ToLocalChecked to ToLocal in node_webstorage - #53959

Merged
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
jasnell:fixup-node-webstorage-tolocalchecked
Jul 21, 2024
Merged

src: switch from ToLocalChecked to ToLocal in node_webstorage#53959
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
jasnell:fixup-node-webstorage-tolocalchecked

Conversation

@jasnell

@jasnelljasnell commented Jul 19, 2024

Copy link
Copy Markdown
Member

No description provided.

@jasnell
jasnell requested review from anonrig and cjihrigJuly 19, 2024 22:03
@nodejs-github-botnodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. labels Jul 19, 2024
@jasnell
jasnellforce-pushed the fixup-node-webstorage-tolocalchecked branch from 531fe5a to 66d9d0dCompareJuly 19, 2024 22:08
juanarbol
juanarbol approved these changes Jul 19, 2024
View reviewed changes

@juanarboljuanarbol left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

I saw something like this a couple weeks ago… r u fuzzing Node?

@jasnell
jasnellforce-pushed the fixup-node-webstorage-tolocalchecked branch from 66d9d0d to 795c8a4CompareJuly 21, 2024 02:29
@jasnelljasnell added the request-ci Add this label to start a Jenkins CI on a PR. label Jul 21, 2024
@github-actionsgithub-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jul 21, 2024
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot

nodejs-github-bot commented Jul 21, 2024•
edited by jasnell
Loading

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/60498/ 💚

@jasnelljasnell added commit-queue Add this label to land a pull request using GitHub Actions. author ready PRs that have at least one approval, no pending requests for changes, and a CI started. and removed needs-ci PRs that need a full CI run. labels Jul 21, 2024
@nodejs-github-botnodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jul 21, 2024
@nodejs-github-bot
nodejs-github-bot merged commit eb85db4 into nodejs:mainJul 21, 2024
@nodejs-github-bot

nodejs-github-bot commented Jul 21, 2024

Copy link
Copy Markdown
Collaborator

Landed in eb85db4

targos pushed a commit that referenced this pull request Jul 28, 2024
@jasnell@targos
src: switch from ToLocalChecked to ToLocal in node_webstorage
75c7e70
PR-URL: #53959
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
@RafaelGSSRafaelGSS mentioned this pull request Jul 30, 2024
Merged
RafaelGSS pushed a commit that referenced this pull request Aug 5, 2024
@jasnell@RafaelGSS
src: switch from ToLocalChecked to ToLocal in node_webstorage
fbf74bc
PR-URL: #53959
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
@legendecaslegendecas mentioned this pull request Nov 25, 2025
Merged
nodejs-github-bot pushed a commit that referenced this pull request Nov 27, 2025
@legendecas
src: simply uint32 to string as it must not fail
430db0d
PR-URL: #60846
Refs: #53959
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
targos pushed a commit that referenced this pull request Nov 27, 2025
@legendecas@targos
src: simply uint32 to string as it must not fail
e243d1d
PR-URL: #60846
Refs: #53959
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
aduh95 pushed a commit that referenced this pull request Jan 9, 2026
@legendecas@aduh95
src: simply uint32 to string as it must not fail
47e13a5
PR-URL: #60846
Refs: #53959
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
RafaelGSS pushed a commit that referenced this pull request Jan 13, 2026
@legendecas@RafaelGSS
src: simply uint32 to string as it must not fail
83d1f41
PR-URL: #60846
Refs: #53959
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
aduh95 pushed a commit that referenced this pull request Apr 4, 2026
@legendecas@aduh95
src: simply uint32 to string as it must not fail
758fe2a
PR-URL: #60846
Refs: #53959
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
aduh95 pushed a commit that referenced this pull request Apr 5, 2026
@legendecas@aduh95
src: simply uint32 to string as it must not fail
6e60f88
PR-URL: #60846
Refs: #53959
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
aduh95 pushed a commit that referenced this pull request Apr 8, 2026
@legendecas@aduh95
src: simply uint32 to string as it must not fail
9e2c5fd
PR-URL: #60846
Refs: #53959
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@anonriganonriganonrig approved these changes
@cjihrigcjihrigcjihrig approved these changes
@juanarboljuanarboljuanarbol approved these changes

Assignees

No one assigned

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.c++Issues and PRs that require attention from people who are familiar with C++.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@jasnell@nodejs-github-bot@anonrig@cjihrig@juanarbol@targos