Uh oh!
There was an error while loading. Please reload this page.
deps: V8: cherry-pick 9812cb486e2b - #53966
Merged
Merged
Conversation
Original commit message: [api] Remove template id from Local constructor According to GCC version 14, this is deprecated in C++20. Change-Id: Iaab14c2db56b3787e391e4d50a9099015169d63f Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/5713754 Reviewed-by: Michael Lippautz <mlippautz@chromium.org> Auto-Submit: Michaël Zasso <mic.besace@gmail.com> Reviewed-by: Camillo Bruni <cbruni@chromium.org> Commit-Queue: Camillo Bruni <cbruni@chromium.org> Cr-Commit-Position: refs/heads/main@{#95084} Refs: v8/v8@9812cb4
nodejs-github-bot
commented
Jul 20, 2024
Collaborator
Review requested:
|
This comment was marked as outdated.
This comment was marked as outdated.
nodejs-github-bot
commented
Jul 20, 2024
Collaborator
nodejs-github-bot
commented
Jul 20, 2024
Collaborator
richardlau
approved these changes
Jul 20, 2024
aduh95
approved these changes
Jul 20, 2024
RafaelGSS
approved these changes
Jul 20, 2024
nodejs-github-bot
commented
Jul 20, 2024
Collaborator
lpinca
approved these changes
Jul 20, 2024
VoltrexKeyva
approved these changes
Jul 20, 2024
jasnell
approved these changes
Jul 21, 2024
gengjiawen
approved these changes
Jul 22, 2024
nodejs-github-bot
commented
Jul 22, 2024
Collaborator
nodejs-github-bot
commented
Jul 22, 2024
Collaborator
Landed in 1c1c9bf |
targos added a commit
that referenced
this pull request
Jul 28, 2024
Original commit message: [api] Remove template id from Local constructor According to GCC version 14, this is deprecated in C++20. Change-Id: Iaab14c2db56b3787e391e4d50a9099015169d63f Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/5713754 Reviewed-by: Michael Lippautz <mlippautz@chromium.org> Auto-Submit: Michaël Zasso <mic.besace@gmail.com> Reviewed-by: Camillo Bruni <cbruni@chromium.org> Commit-Queue: Camillo Bruni <cbruni@chromium.org> Cr-Commit-Position: refs/heads/main@{#95084} Refs: v8/v8@9812cb4 PR-URL: #53966 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Merged
RafaelGSS pushed a commit
that referenced
this pull request
Aug 5, 2024
Original commit message: [api] Remove template id from Local constructor According to GCC version 14, this is deprecated in C++20. Change-Id: Iaab14c2db56b3787e391e4d50a9099015169d63f Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/5713754 Reviewed-by: Michael Lippautz <mlippautz@chromium.org> Auto-Submit: Michaël Zasso <mic.besace@gmail.com> Reviewed-by: Camillo Bruni <cbruni@chromium.org> Commit-Queue: Camillo Bruni <cbruni@chromium.org> Cr-Commit-Position: refs/heads/main@{#95084} Refs: v8/v8@9812cb4 PR-URL: #53966 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Original commit message:
Refs: v8/v8@9812cb4
This should get rid of very noisy warnings that happen with
fedora-latesthosts in CI.