Uh oh!
There was an error while loading. Please reload this page.
src: start using ncrypto for CSPRNG calls - #53984
Merged
Merged
Conversation
nodejs-github-bot
commented
Jul 21, 2024
Collaborator
Review requested:
|
jasnellforce-pushed
the
start-using-ncrypto
branch
from
July 21, 2024 21:12
4df80ae to
6fd9b19Compare
This comment was marked as outdated.
This comment was marked as outdated.
anonrig
approved these changes
Jul 21, 2024
Uh oh!
There was an error while loading. Please reload this page.
This comment was marked as outdated.
This comment was marked as outdated.
Ethan-Arrowood
approved these changes
Jul 22, 2024
tniessen
commented
Jul 22, 2024
Member
FWIW, this partially undoes @bnoordhuis's attempt at making this more difficult to misuse (see https://github.com/nodejs-private/node-private/pull/346#discussion_r967795383 if you have access). |
jasnell
commented
Jul 22, 2024
MemberAuthor
I never really agreed that that made any real difference one way or the other but if folks feel strongly about it I can retain that. |
Collaborator
tniessen
approved these changes
Jul 22, 2024
nodejs-github-bot
commented
Jul 23, 2024
Collaborator
Landed in c112b4b |
targos pushed a commit
that referenced
this pull request
Jul 28, 2024
PR-URL: #53984 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Ethan Arrowood <ethan@arrowood.dev> Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Merged
RafaelGSS pushed a commit
that referenced
this pull request
Aug 5, 2024
PR-URL: #53984 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Ethan Arrowood <ethan@arrowood.dev> Reviewed-By: Tobias Nießen <tniessen@tnie.de>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.