Skip to content

src: move spkac methods to ncrypto - #53985

Closed
jasnell wants to merge 1 commit into
nodejs:mainfrom
jasnell:jsnell/move-crypto-spkac-to-ncrypto
Closed

src: move spkac methods to ncrypto#53985
jasnell wants to merge 1 commit into
nodejs:mainfrom
jasnell:jsnell/move-crypto-spkac-to-ncrypto

Conversation

@jasnell

@jasnelljasnell commented Jul 21, 2024

Copy link
Copy Markdown
Member

No description provided.

@jasnell
jasnell requested review from anonrig and tniessenJuly 21, 2024 22:59
@nodejs-github-bot

nodejs-github-bot commented Jul 21, 2024

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/crypto
  • @nodejs/security-wg

@nodejs-github-botnodejs-github-bot added lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run. labels Jul 21, 2024
@jasnelljasnell added request-ci Add this label to start a Jenkins CI on a PR. and removed lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run. labels Jul 21, 2024
@jasnell
jasnellforce-pushed the jsnell/move-crypto-spkac-to-ncrypto branch from ea5104c to 9afde2dCompareJuly 21, 2024 23:06
@github-actionsgithub-actionsBot added request-ci-failed An error occurred while starting CI via request-ci label, and manual interventon is needed. and removed request-ci Add this label to start a Jenkins CI on a PR. labels Jul 21, 2024
@github-actions

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot

nodejs-github-bot commented Jul 21, 2024•
edited by jasnell
Loading

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/60518/ 💛

@jasnelljasnell added crypto Issues and PRs related to the crypto subsystem. c++ Issues and PRs that require attention from people who are familiar with C++. and removed request-ci-failed An error occurred while starting CI via request-ci label, and manual interventon is needed. labels Jul 21, 2024
@jasnell

jasnell commented Jul 21, 2024

Copy link
Copy Markdown
MemberAuthor

@nodejs/crypto

anonrig
anonrig reviewed Jul 21, 2024
View reviewed changes
Comment threaddeps/ncrypto/ncrypto.cc Outdated
Comment threaddeps/ncrypto/ncrypto.cc Outdated
Comment threaddeps/ncrypto/ncrypto.cc Outdated
Comment threaddeps/ncrypto/ncrypto.cc Outdated
anonrig
anonrig reviewed Jul 21, 2024
View reviewed changes
Comment threaddeps/ncrypto/ncrypto.cc Outdated
anonrig
anonrig reviewed Jul 21, 2024
View reviewed changes
Comment threaddeps/ncrypto/ncrypto.cc Outdated
@jasnell
jasnellforce-pushed the jsnell/move-crypto-spkac-to-ncrypto branch from 9afde2d to 17c1f41CompareJuly 22, 2024 14:32
@jasnell
jasnell requested a review from anonrigJuly 22, 2024 14:35
anonrig
anonrig reviewed Jul 22, 2024
View reviewed changes
Comment threaddeps/ncrypto/ncrypto.cc
@anonriganonrig added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels Jul 22, 2024
@github-actionsgithub-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jul 22, 2024
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot

nodejs-github-bot commented Jul 22, 2024•
edited by jasnell
Loading

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/60542/ 💛

@anonriganonrig added commit-queue Add this label to land a pull request using GitHub Actions. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels Jul 25, 2024
jasnell added a commit that referenced this pull request Aug 5, 2024
@jasnell
src: move spkac methods to ncrypto
cf21220
PR-URL: #53985
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
@jasnell

jasnell commented Aug 5, 2024

Copy link
Copy Markdown
MemberAuthor

Landed in cf21220

@jasnelljasnell closed this Aug 5, 2024
targos pushed a commit that referenced this pull request Aug 14, 2024
@jasnell@targos
src: move spkac methods to ncrypto
e619133
PR-URL: #53985
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
@RafaelGSSRafaelGSS mentioned this pull request Aug 19, 2024
Merged
npaun pushed a commit to npaun/ncrypto that referenced this pull request Sep 18, 2025
@jasnell@npaun
src: move spkac methods to ncrypto
126fcd7
PR-URL: nodejs/node#53985
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@anonriganonriganonrig approved these changes
@tniessentniessenAwaiting requested review from tniessen

Assignees

No one assigned

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.c++Issues and PRs that require attention from people who are familiar with C++.cryptoIssues and PRs related to the crypto subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@jasnell@nodejs-github-bot@anonrig@targos