Skip to content

tools: add tsc checker - #54069

Closed
1ilsang wants to merge 4 commits into
nodejs:mainfrom
1ilsang:feat/typings-lint
Closed

tools: add tsc checker#54069
1ilsang wants to merge 4 commits into
nodejs:mainfrom
1ilsang:feat/typings-lint

Conversation

@1ilsang

@1ilsang1ilsang commented Jul 27, 2024

Copy link
Copy Markdown
Member

Motivation

I've noticed that the declare files are not being checked(#54063, #54064) properly.

So I'd like to add lint for those files.

AS-IS

None

TO-BE

image
$ make lint-ts

If this PR is approved, I would also like to apply typescript-eslint(related #54065).

What do you think? thanks.

@nodejs-github-botnodejs-github-bot added build Issues and PRs related to build files or the CI. needs-ci PRs that need a full CI run. tools Issues and PRs related to the tools directory. labels Jul 27, 2024
@aduh95

Copy link
Copy Markdown
Contributor

Let's not vendor typescript, the diff is unnecessary big.

@targos

Copy link
Copy Markdown
Member

Technically we already vendor TypeScript in https://github.com/nodejs/node/blob/main/test/fixtures/snapshot/typescript.js

@1ilsang

1ilsang commented Jul 31, 2024

Copy link
Copy Markdown
MemberAuthor
image

tsconfig.json

image

@targos@aduh95 Hi.

Unfortunately, We don't have Typescript declare files, so we can't check the declare file.

image

Is this the way to do it? Any advice would be appreciated.

Here is example PR

@1ilsang1ilsang closed this Jan 16, 2025
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

buildIssues and PRs related to build files or the CI.needs-ciPRs that need a full CI run.toolsIssues and PRs related to the tools directory.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@1ilsang@aduh95@targos@nodejs-github-bot