deps: update V8 to 12.8 by targos · Pull Request #54077 · nodejs/node

targos · 2024-07-28T08:17:36Z

Notable changes:

nodejs-github-bot · 2024-07-28T08:17:42Z

Review requested:

@nodejs/gyp
@nodejs/security-wg
@nodejs/v8-update

targos · 2024-07-28T09:02:14Z

Trying Windows again with the new commit: https://ci.nodejs.org/job/node-test-commit-windows-fanned/64381/

targos · 2024-07-28T10:00:32Z

@nodejs/platform-s390 There's a failing V8 test: https://ci.nodejs.org/job/node-test-commit-v8-linux/6098/nodes=rhel8-s390x,v8test=v8test/console

targos · 2024-07-28T10:47:50Z

We also have a compiler error with ubi81_sharedlibs_openssl111fips_x64:

12:06:12 In file included from ../deps/v8/include/v8-isolate.h:21,
12:06:12 from ../deps/v8/include/v8-snapshot.h:9,
12:06:12 from ../deps/v8/include/v8-context.h:15,
12:06:12 from ../deps/v8/include/v8.h:26,
12:06:12 from ../src/node_external_reference.h:9,
12:06:12 from ../src/node_builtins.h:13,
12:06:12 from ../src/node_builtins.cc:1:
12:06:12 ../deps/v8/include/v8-function-callback.h: In instantiation of 'v8::Isolate* v8::PropertyCallbackInfo<F>::GetIsolate() const [with T = v8::Value]':
12:06:12 ../src/node_builtins.cc:655:62: required from here
12:06:12 ../deps/v8/include/v8-function-callback.h:695:11: error: dereferencing type-punned pointer will break strict-aliasing rules [-Werror=strict-aliasing]
12:06:12 695 | return *reinterpret_cast<Isolate**>(&args_[kIsolateIndex]);
12:06:12 | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
12:06:12 cc1plus: all warnings being treated as errors
12:06:12 make[2]: *** [libnode.target.mk:439: /home/iojs/build/workspace/node-test-commit-linux-containered/out/Release/obj.target/libnode/src/node_builtins.o] Error 1

miladfarca · 2024-07-28T12:09:37Z

@targos that test is knows to be flaky (on other platforms as well): https://issues.chromium.org/issues/42200980
rerunning the tests should pass it.

ronag · 2024-07-29T06:00:46Z

I think this also adds support for DisposableStack and AsyncDisposableStack. Maybe notable?

targos · 2024-07-29T06:19:19Z

@ronag it doesn't seem to (DisposableStack is not defined)

ronag · 2024-07-29T06:28:46Z

@ronag it doesn't seem to (DisposableStack is not defined)

Ah, weird. There are references to it in the changes so I thought it was included.

Refs: https://chromium-review.googlesource.com/c/v8/v8/+/5300826 PR-URL: #54077 Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>

Refs: https://chromium-review.googlesource.com/c/v8/v8/+/5447267 Co-authored-by: Michaël Zasso <targos@protonmail.com> PR-URL: #54077 Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>

Refs: v8/v8@e30e228 PR-URL: #54077 Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>

Refs: v8/v8@f8fa220 PR-URL: #54077 Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>

As V8 has moved away from wrapper-descriptor-based CppHeap, this patch: 1. Create the CppHeap without using wrapper descirptors. 2. Deprecates node::SetCppgcReference() in favor of v8::Object::Wrap() since the wrapper descriptor is no longer relevant. It is still kept as a compatibility layer for addons that need to also work on Node.js versions without v8::Object::Wrap(). PR-URL: #54077 Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>

Add/remove abseil files introduced by V8 12.7 update found by: ``` git diff-tree --no-commit-id --name-status 0ec8f7e -r | grep '^[AD].*abseil.*' ``` PR-URL: #54077 Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>

Refs: v8/v8@06847fb PR-URL: #54077 Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>

Two fields on the `v8::FastApiCallbackOptions` struct were deprecated recently: `fallback` and `wasm_memory`. This PR removes uses of these two fields in node.js. PR-URL: #54077 Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>

targos · 2024-08-16T14:05:58Z

Landed in 7fab6e8...f0134fa

PR-URL: #54077 Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>

It's causing compiler errors with some classes on Xcode 11 and the attribute should have no runtime effect. PR-URL: #54077 Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>

PR-URL: nodejs/node#54077 Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>

It's causing compiler errors with some classes on Xcode 11 and the attribute should have no runtime effect. PR-URL: nodejs/node#54077 Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>

PR-URL: nodejs/node#54077 Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>

It's causing compiler errors with some classes on Xcode 11 and the attribute should have no runtime effect. PR-URL: nodejs/node#54077 Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>

PR-URL: nodejs/node#54077 Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>

It's causing compiler errors with some classes on Xcode 11 and the attribute should have no runtime effect. PR-URL: nodejs/node#54077 Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>

PR-URL: nodejs/node#54077 Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>

It's causing compiler errors with some classes on Xcode 11 and the attribute should have no runtime effect. PR-URL: nodejs/node#54077 Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>

PR-URL: #54077 Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>

zcbenz · 2024-09-10T01:17:25Z

It seems that wrapping a cppgc Object with v8::Object has been simplified a lot, would it be possible to wrap a cppgc Object with Node-API now?

nodejs-github-bot added build Issues and PRs related to build files or the CI. needs-ci PRs that need a full CI run. v8 engine Issues and PRs related to the V8 dependency. labels Jul 28, 2024

targos mentioned this pull request Jul 28, 2024
deps: update V8 to 12.7 #53651
Closed

targos added the semver-major PRs that contain breaking changes and should be released in the next major version. label Jul 28, 2024

targos force-pushed the v8-128 branch from f09d022 to 8560272Compare July 28, 2024 08:22

targos added the request-ci Add this label to start a Jenkins CI on a PR. label Jul 28, 2024

github-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jul 28, 2024

This comment was marked as outdated.
Sign in to view

targos force-pushed the v8-128 branch from 11b6b21 to f6c7e85Compare July 28, 2024 09:52

targos mentioned this pull request Jul 28, 2024
build: drop experimental support for Windows <10 #54079
Merged

This comment was marked as outdated.
Sign in to view

targos force-pushed the v8-128 branch from f6c7e85 to 11f49feCompare August 7, 2024 14:31

targos added the request-ci Add this label to start a Jenkins CI on a PR. label Aug 7, 2024

github-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Aug 7, 2024

This comment was marked as outdated.
Sign in to view

targos closed this Aug 16, 2024

RafaelGSS mentioned this pull request Aug 19, 2024
doc: reserve ABI 130 for Electron 33 #54383
Merged

RafaelGSS mentioned this pull request Oct 9, 2024
2024-10-16, Version 23.0.0 (Current) #55338
Merged

H4ad mentioned this pull request Nov 10, 2024
Revisit Fast APIs implementations & New implementations nodejs/performance#182
Open

aduh95 mentioned this pull request Jan 22, 2025
libuv assertion on Windows with Node.js 23.x #56645
Closed

nodejs-github-bot mentioned this pull request Jan 31, 2025
deps: update V8 to 13.0 #55014
Closed

RafaelGSS mentioned this pull request Oct 13, 2025
2025-10-15, Version 25.0.0 (Current) #59896
Merged
9 tasks

edemaine mentioned this pull request Feb 27, 2026
javascript.regular_expressions: duplicate named groups runtime support mdn/browser-compat-data#29146
Merged

RafaelGSS mentioned this pull request Apr 27, 2026
2026-05-05, Version 26.0.0 (Current) #62526
Merged

Uh oh!

Uh oh!

Conversation

targos commented Jul 28, 2024

Uh oh!

nodejs-github-bot commented Jul 28, 2024

Uh oh!

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

targos commented Jul 28, 2024

Uh oh!

This comment was marked as outdated.

targos commented Jul 28, 2024

Uh oh!

targos commented Jul 28, 2024

Uh oh!

miladfarca commented Jul 28, 2024

Uh oh!

ronag commented Jul 29, 2024

Uh oh!

targos commented Jul 29, 2024

Uh oh!

ronag commented Jul 29, 2024

Uh oh!

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

targos commented Aug 16, 2024

Uh oh!

zcbenz commented Sep 10, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

13 participants