watch: reload changes in contents of --env-file by marekpiechut · Pull Request #54109 · nodejs/node

marekpiechut · 2024-07-29T22:44:22Z

Make sure we watch and reload on env file changes.
Ignore env file in parent process, so child process can reload current vars when we recreate it.

Fixes: #54001

I've noticed now that it's probably a duplicate of #54033.

Feel free to close or reuse tests from here in the other PR if you plan on merging it.
It was a nice small bug to get feet wet with Node internals anyway. 👋

Make sure we watch and reload on env file changes. Ignore env file in parent process, so child process can reload current vars when we recreate it. Fixes: nodejs#54001

nodejs-github-bot · 2024-07-29T22:44:27Z

Review requested:

@nodejs/startup

nodejs-github-bot · 2024-07-31T03:11:20Z

CI: https://ci.nodejs.org/job/node-test-pull-request/60759/

codecov · 2024-07-31T04:45:47Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.07%. Comparing base (cf9a814) to head (a8eecc8).
Report is 540 commits behind head on main.

Additional details and impacted files

@@ Coverage Diff @@## main #54109 +/- ##
=======================================
Coverage 87.07% 87.07% =======================================
Files 643 643 Lines 181590 181576 -14 Branches 34893 34892 -1 =======================================
- Hits 158114 158109 -5 + Misses 16754 16746 -8 + Partials 6722 6721 -1

Files with missing lines	Coverage Δ
src/node.cc	`74.03% <100.00%> (ø)`

... and 31 files with indirect coverage changes

marekpiechut · 2024-07-31T09:06:34Z

Fixed linter issues.

nodejs-github-bot · 2024-08-02T14:19:20Z

CI: https://ci.nodejs.org/job/node-test-pull-request/60833/

marekpiechut · 2024-08-04T20:18:57Z

I see there are test failures in the latest check. I tried to look into them, but they all look weird. There are some unrelated test failures and build issues on Windows, etc.

@MoLow @anonrig could you give some advice how to continue with that?

MoLow · 2024-08-04T20:52:09Z

none of those seem related

nodejs-github-bot · 2024-08-04T20:52:10Z

CI: https://ci.nodejs.org/job/node-test-pull-request/60873/

nodejs-github-bot · 2024-08-05T07:01:57Z

CI: https://ci.nodejs.org/job/node-test-pull-request/60879/

nodejs-github-bot · 2024-08-05T09:25:44Z

CI: https://ci.nodejs.org/job/node-test-pull-request/60880/

nodejs-github-bot · 2024-08-05T10:41:34Z

Landed in a816688

tniessen · 2024-08-05T11:32:31Z

Are there no NODE_OPTIONS that should affect the parent process?

MoLow · 2024-08-05T18:59:48Z

@tniessen I am not sure what you mean? can you elaborate?
passing --env-file will be correctly forwarded to inner process regardless of if it is used with NODE_OPTIONS or without

Make sure we watch and reload on env file changes. Ignore env file in parent process, so child process can reload current vars when we recreate it. Fixes: #54001 PR-URL: #54109 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il>

dchenk · 2025-01-12T19:24:45Z

This change didn't cover the --env-file-if-exists flag. Please see #49148 (comment)

watch: reload changes in contents of --env-file
cdeff79
Make sure we watch and reload on env file changes. Ignore env file in parent process, so child process can reload current vars when we recreate it. Fixes: nodejs#54001

nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. labels Jul 29, 2024

anonrig approved these changes Jul 30, 2024
View reviewed changes

anonrig added the request-ci Add this label to start a Jenkins CI on a PR. label Jul 31, 2024

github-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jul 31, 2024

watch: reload changes in contents of --env-file (fix liner issues)
a8eecc8

MoLow approved these changes Aug 2, 2024
View reviewed changes

MoLow added the request-ci Add this label to start a Jenkins CI on a PR. label Aug 2, 2024

github-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Aug 2, 2024

MoLow added commit-queue Add this label to land a pull request using GitHub Actions. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. labels Aug 5, 2024

nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Aug 5, 2024

nodejs-github-bot merged commit a816688 into nodejs:mainAug 5, 2024

marekpiechut deleted the watch-env-file branch August 5, 2024 11:25

RafaelGSS mentioned this pull request Aug 19, 2024
v22.7.0 proposal #54452
Merged

targos added the dont-land-on-v20.x label Sep 21, 2024

gorankarlic mentioned this pull request Nov 26, 2024
--watch-path also watches --env file directory tree in >=22.7 #55913
Closed

Uh oh!

Uh oh!

Conversation

marekpiechut commented Jul 29, 2024

Uh oh!

nodejs-github-bot commented Jul 29, 2024

Uh oh!

nodejs-github-bot commented Jul 31, 2024

Uh oh!

codecovBot commented Jul 31, 2024• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

marekpiechut commented Jul 31, 2024

Uh oh!

nodejs-github-bot commented Aug 2, 2024

Uh oh!

marekpiechut commented Aug 4, 2024

Uh oh!

MoLow commented Aug 4, 2024

Uh oh!

nodejs-github-bot commented Aug 4, 2024

Uh oh!

nodejs-github-bot commented Aug 5, 2024

Uh oh!

nodejs-github-bot commented Aug 5, 2024

Uh oh!

nodejs-github-bot commented Aug 5, 2024

Uh oh!

tniessen commented Aug 5, 2024

Uh oh!

MoLow commented Aug 5, 2024

Uh oh!

dchenk commented Jan 12, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

codecovBot commented Jul 31, 2024•
edited
Loading