Skip to content

Update required python version - #54112

Closed
d3x0r wants to merge 1 commit into
nodejs:mainfrom
d3x0r:patch-2
Closed

Update required python version#54112
d3x0r wants to merge 1 commit into
nodejs:mainfrom
d3x0r:patch-2

Conversation

@d3x0r

Copy link
Copy Markdown
Contributor

Configure scripts use := operator now, which requires python 3.8.

File "tools/gyp/pylib/gyp/common.py", line 435
if CC := os.environ.get("CC_target") or os.environ.get("CC"):

Configure scripts use := operator now, which requires python 3.8.
File "tools/gyp/pylib/gyp/common.py", line 435
if CC := os.environ.get("CC_target") or os.environ.get("CC"):
@nodejs-github-botnodejs-github-bot added build Issues and PRs related to build files or the CI. doc Issues and PRs related to the documentations. labels Jul 30, 2024
@lpinca

Copy link
Copy Markdown
Member

Python 3.6 is still officially supported

acceptable_pythons = ((3,13), (3,12), (3,11), (3,10), (3,9), (3,8), (3,7), (3,6))

I guess we should update that.

@avivkelleravivkeller added the python PRs and issues that require attention from people who are familiar with Python. label Aug 4, 2024
@avivkeller

avivkeller commented Aug 13, 2024

Copy link
Copy Markdown
Member

Hey, @d3x0r, are you still planning to add the parts that @lpinca mentioned?

FWIW there are also merge conflicts.

@d3x0r

Copy link
Copy Markdown
ContributorAuthor

I can't do much more than start this - if someone wants to start a new PR or take over this one that'd be better, I'm sure there's lots of small details I don't know about.

@avivkelleravivkeller self-assigned this Aug 13, 2024
@avivkeller

Copy link
Copy Markdown
Member

No worries! I'll update the required files later today

@avivkeller

Copy link
Copy Markdown
Member

#54358 has all the changes needed. @d3x0r has been marked as a Co-Author.

@avivkeller

Copy link
Copy Markdown
Member

Closing in favor

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

buildIssues and PRs related to build files or the CI.docIssues and PRs related to the documentations.pythonPRs and issues that require attention from people who are familiar with Python.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@d3x0r@lpinca@avivkeller@nodejs-github-bot