Skip to content

module: remove outdated comment - #54118

Merged
aduh95 merged 1 commit into
nodejs:mainfrom
targos:module-rm-comment
Aug 1, 2024
Merged

module: remove outdated comment#54118
aduh95 merged 1 commit into
nodejs:mainfrom
targos:module-rm-comment

Conversation

@targos

Copy link
Copy Markdown
Member

Refs: #53822

@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/loaders

@nodejs-github-botnodejs-github-bot added esm Issues and PRs related to the ECMAScript Modules implementation. needs-ci PRs that need a full CI run. labels Jul 30, 2024
@aduh95aduh95 added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. and removed needs-ci PRs that need a full CI run. labels Jul 30, 2024
@targostargos added the commit-queue Add this label to land a pull request using GitHub Actions. label Jul 31, 2024
@codecov

codecovBot commented Jul 31, 2024

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.07%. Comparing base (890760b) to head (9f4483a).
Report is 537 commits behind head on main.

Additional details and impacted files
@@ Coverage Diff @@## main #54118 +/- ##
==========================================
+ Coverage 87.04% 87.07% +0.02% 
==========================================
Files 643 643 Lines 181589 181588 -1 Branches 34883 34888 +5 ==========================================
+ Hits 158072 158110 +38 + Misses 16785 16750 -35 + Partials 6732 6728 -4 
Files with missing linesCoverage Δ
lib/internal/modules/esm/resolve.js96.45% <ø> (-0.01%)⬇️

... and 27 files with indirect coverage changes

@nodejs-github-botnodejs-github-bot added commit-queue-failed An error occurred while landing this pull request using GitHub Actions. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels Aug 1, 2024
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator
Commit Queue failed
- Loading data for nodejs/node/pull/54118
✔ Done loading data for nodejs/node/pull/54118
----------------------------------- PR info ------------------------------------
Title module: remove outdated comment (#54118)
Author Michaël Zasso <targos@protonmail.com> (@targos)
Branch targos:module-rm-comment -> nodejs:main
Labels esm, author ready
Commits 1
- module: remove outdated comment
Committers 1
- Michaël Zasso <targos@protonmail.com>
PR-URL: https://github.com/nodejs/node/pull/54118
Refs: https://github.com/nodejs/node/pull/53822
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/54118
Refs: https://github.com/nodejs/node/pull/53822
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
--------------------------------------------------------------------------------
ℹ This PR was created on Tue, 30 Jul 2024 10:13:09 GMT
✔ Approvals: 4
✔ - Juan José Arboleda (@juanarbol): https://github.com/nodejs/node/pull/54118#pullrequestreview-2207278842
✔ - Antoine du Hamel (@aduh95) (TSC): https://github.com/nodejs/node/pull/54118#pullrequestreview-2207294695
✔ - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/54118#pullrequestreview-2208546573
✔ - Trivikram Kamat (@trivikr): https://github.com/nodejs/node/pull/54118#pullrequestreview-2211474577
✔ Last GitHub CI successful
✘ No Jenkins CI runs detected
--------------------------------------------------------------------------------
✔ Aborted `git node land` session in /home/runner/work/node/node/.ncu
https://github.com/nodejs/node/actions/runs/10196534245

@aduh95
aduh95 merged commit 00c0644 into nodejs:mainAug 1, 2024
@aduh95

Copy link
Copy Markdown
Contributor

Landed in 00c0644

@targos
targos deleted the module-rm-comment branch August 1, 2024 11:12
targos added a commit that referenced this pull request Aug 14, 2024
Refs: #53822
PR-URL: #54118
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
@RafaelGSSRafaelGSS mentioned this pull request Aug 19, 2024
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.commit-queue-failedAn error occurred while landing this pull request using GitHub Actions.esmIssues and PRs related to the ECMAScript Modules implementation.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants

@targos@nodejs-github-bot@aduh95@lpinca@trivikr@juanarbol