Skip to content

doc: add content for Blob.bytes() - #54121

Closed
sendoru wants to merge 2 commits into
nodejs:mainfrom
sendoru:doc-blob-bytes
Closed

doc: add content for Blob.bytes()#54121
sendoru wants to merge 2 commits into
nodejs:mainfrom
sendoru:doc-blob-bytes

Conversation

@sendoru

@sendorusendoru commented Jul 30, 2024•
edited
Loading

Copy link
Copy Markdown
Contributor

This fixes#54105, and adds missing docstring for Blob.bytes() as well.

@sendoru
doc: add content for Blob.bytes()
9ef0086
Fixes: nodejs#54105
Refs: nodejs#53221
@sendoru
buffer: add docstring for Blob.bytes()
1a12d83
Add docstring that clarifies the return type of Blob.bytes()
(`Promise<Uint8Array>`)
Refs: nodejs#53221
@nodejs-github-botnodejs-github-bot added the needs-ci PRs that need a full CI run. label Jul 30, 2024
@jakecastelli

jakecastelli commented Jul 30, 2024

Copy link
Copy Markdown
Member

Thanks for your contribution, there are two PRs (first + second) that have already opened to fix the issue and they are slightly earlier than yours 😞 would you mind reviewing them instead? 🙏

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

needs-ciPRs that need a full CI run.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

blob.bytes() not documented

3 participants

@sendoru@jakecastelli@nodejs-github-bot