Skip to content

doc: remove unused imports from worker_threads.md - #54147

Merged
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
debbs061:unused-import
Jul 31, 2024
Merged

doc: remove unused imports from worker_threads.md#54147
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
debbs061:unused-import

Conversation

@debbs061

@debbs061debbs061 commented Jul 31, 2024

Copy link
Copy Markdown
Contributor

Remove unused imports from worker_threads.md.

  • Removed once import from node:events as it was not used in the code.
  • Removed isMainThread import from node:worker_threads as it was not used in the code.

@nodejs-github-botnodejs-github-bot added doc Issues and PRs related to the documentations. worker Issues and PRs related to Worker support. labels Jul 31, 2024
@aduh95aduh95 changed the title typings: remove unused imports from worker_threads.mddoc: remove unused imports from worker_threads.mdJul 31, 2024

@deokjinkimdeokjinkim left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@debbs061 Thank you for contribution. Could you change subsystem from typings to doc in commit title? You can force push with -f option.

@aduh95aduh95 added the fast-track PRs that do not need to wait for 48 hours to land. label Jul 31, 2024
@github-actions

Copy link
Copy Markdown
Contributor

Fast-track has been requested by @aduh95. Please 👍 to approve.

@aduh95aduh95 added the commit-queue Add this label to land a pull request using GitHub Actions. label Jul 31, 2024
@nodejs-github-botnodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jul 31, 2024
@nodejs-github-bot
nodejs-github-bot merged commit 7941b4b into nodejs:mainJul 31, 2024
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

Landed in 7941b4b

targos pushed a commit that referenced this pull request Aug 14, 2024
PR-URL: #54147
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Deokjin Kim <deokjin81.kim@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@RafaelGSSRafaelGSS mentioned this pull request Aug 19, 2024
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docIssues and PRs related to the documentations.fast-trackPRs that do not need to wait for 48 hours to land.workerIssues and PRs related to Worker support.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants

@debbs061@nodejs-github-bot@lpinca@deokjinkim@aduh95@targos