Uh oh!
There was an error while loading. Please reload this page.
deps: update amaro to 0.0.6 - #54199
Closed
nodejs-github-bot wants to merge 2 commits into
Closed
Conversation
nodejs-github-bot
commented
Aug 4, 2024
CollaboratorAuthor
Review requested:
|
anonrig
approved these changes
Aug 4, 2024
marco-ippolito
approved these changes
Aug 4, 2024
nodejs-github-bot
commented
Aug 4, 2024
CollaboratorAuthor
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@## main #54199 +/- ##
==========================================
+ Coverage 87.07% 87.09% +0.01%
==========================================
Files 643 647 +4 Lines 181583 181851 +268 Branches 34886 34921 +35 ==========================================
+ Hits 158114 158383 +269 + Misses 16751 16748 -3 - Partials 6718 6720 +2 |
nodejs-github-bot
commented
Aug 4, 2024
CollaboratorAuthor
himself65
approved these changes
Aug 4, 2024
jakecastelli
approved these changes
Aug 4, 2024
mertcanaltin
approved these changes
Aug 4, 2024
Contributor
Fast-track has been requested by @marco-ippolito. Please 👍 to approve. |
marco-ippolito
commented
Aug 5, 2024
Member
fast tracking as Id like to include it on v22.6.0 |
RafaelGSS
approved these changes
Aug 5, 2024
nodejs-github-bot
commented
Aug 5, 2024
CollaboratorAuthor
Commit Queue failed- Loading data for nodejs/node/pull/54199 ✔ Done loading data for nodejs/node/pull/54199 ----------------------------------- PR info ------------------------------------ Title deps: update amaro to 0.0.6 (#54199) ⚠ Could not retrieve the email or name of the PR author's from user's GitHub profile! Branch nodejs-github-bot:actions/tools-update-amaro -> nodejs:main Labels lib / src, fast-track, author ready, needs-ci, dependencies, commit-queue-rebase, strip-types Commits 2 - deps: update amaro to 0.0.5 - deps: update amaro to 0.0.6 Committers 1 - Node.js GitHub Bot <github-bot@iojs.org> PR-URL: https://github.com/nodejs/node/pull/54199 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Zeyu "Alex" Yang <himself65@outlook.com> Reviewed-By: Jake Yuesong Li <jake.yuesong@gmail.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/54199 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Zeyu "Alex" Yang <himself65@outlook.com> Reviewed-By: Jake Yuesong Li <jake.yuesong@gmail.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> -------------------------------------------------------------------------------- ℹ This PR was created on Sun, 04 Aug 2024 00:30:47 GMT ✔ Approvals: 5 ✔ - Yagiz Nizipli (@anonrig) (TSC): https://github.com/nodejs/node/pull/54199#pullrequestreview-2217282080 ✔ - Marco Ippolito (@marco-ippolito) (TSC): https://github.com/nodejs/node/pull/54199#pullrequestreview-2217417552 ✔ - Zeyu "Alex" Yang (@himself65): https://github.com/nodejs/node/pull/54199#pullrequestreview-2217492450 ✔ - Jake Yuesong Li (@jakecastelli): https://github.com/nodejs/node/pull/54199#pullrequestreview-2217736580 ✔ - Rafael Gonzaga (@RafaelGSS) (TSC): https://github.com/nodejs/node/pull/54199#pullrequestreview-2219225527 ℹ This PR is being fast-tracked ✘ GitHub CI is still running ℹ Last Full PR CI on 2024-08-04T07:34:43Z: https://ci.nodejs.org/job/node-test-pull-request/60860/ - Querying data for job/node-test-pull-request/60860/ ✔ Last Jenkins CI successful -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/10251306992 |
marco-ippolito pushed a commit
that referenced
this pull request
Aug 5, 2024
PR-URL: #54199 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Zeyu "Alex" Yang <himself65@outlook.com> Reviewed-By: Jake Yuesong Li <jake.yuesong@gmail.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
marco-ippolito pushed a commit
that referenced
this pull request
Aug 5, 2024
PR-URL: #54199 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Zeyu "Alex" Yang <himself65@outlook.com> Reviewed-By: Jake Yuesong Li <jake.yuesong@gmail.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
marco-ippolito
commented
Aug 5, 2024
Member
Landed in bc6f895...b95eac5 |
marco-ippolito pushed a commit
that referenced
this pull request
Aug 5, 2024
PR-URL: #54199 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Zeyu "Alex" Yang <himself65@outlook.com> Reviewed-By: Jake Yuesong Li <jake.yuesong@gmail.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
marco-ippolito pushed a commit
that referenced
this pull request
Aug 5, 2024
PR-URL: #54199 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Zeyu "Alex" Yang <himself65@outlook.com> Reviewed-By: Jake Yuesong Li <jake.yuesong@gmail.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an automated update of amaro to 0.0.6.