Uh oh!
There was an error while loading. Please reload this page.
test: add subtests to test-node-run - #54204
Merged
nodejs-github-bot merged 2 commits intoAug 6, 2024
Merged
Conversation
Added two subtests to test-node-run. First one is about unparsable package.json file, and the second one is about there is no "script" fields in package.json
anonrig
approved these changes
Aug 4, 2024
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
anonrig
approved these changes
Aug 4, 2024
nodejs-github-bot
commented
Aug 4, 2024
Collaborator
mertcanaltin
approved these changes
Aug 4, 2024
benjamingr
approved these changes
Aug 4, 2024
lpinca
approved these changes
Aug 4, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@## main #54204 +/- ##
=======================================
Coverage 87.09% 87.09% =======================================
Files 647 647 Lines 181851 181845 -6 Branches 34916 34918 +2 =======================================
+ Hits 158383 158384 +1 + Misses 16749 16736 -13 - Partials 6719 6725 +6 |
trivikr
approved these changes
Aug 4, 2024
nodejs-github-bot
commented
Aug 6, 2024
Collaborator
Landed in 359b428 |
targos pushed a commit
that referenced
this pull request
Aug 14, 2024
Added two subtests to test-node-run. First one is about unparsable package.json file, and the second one is about there is no "script" fields in package.json PR-URL: #54204 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added two subtests to test-node-run.
First one is about unparsable package.json file, and the second one is about there is no "script" fields in package.json