Uh oh!
There was an error while loading. Please reload this page.
doc: run license-builder - #54322
Closed
github-actions[bot] wants to merge 1 commit into
Closed
Conversation
nodejs-github-bot
commented
Aug 12, 2024
Collaborator
Review requested:
|
marco-ippolito
approved these changes
Aug 12, 2024
aymen94
approved these changes
Aug 12, 2024
richardlau
previously approved these changes
Aug 12, 2024
avivkeller
commented
Aug 12, 2024
Member
Hey, just wanted to point out that the license builder script accounted for the header, so if this lands, the license wouldn't match that of c-ares. The script should be updated instead of landing this IMO. |
avivkeller
commented
Aug 12, 2024
Member
I suggest not landing this, and instead landing #54335 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
License is likely out of date. This is an automatically generated PR by the
license-builder.ymlGitHub Action, which runslicense-builder.shand submits a new PR or updates an existing PR.