buffer: optimize createFromString

[ronag]

buffers/buffer-from.js n=800000 len=100 source='array' *** -2.41 % ±0.75% ±0.99% ±1.29%
buffers/buffer-from.js n=800000 len=100 source='arraybuffer-middle' 0.17 % ±1.63% ±2.18% ±2.83%
buffers/buffer-from.js n=800000 len=100 source='arraybuffer' -0.98 % ±1.29% ±1.72% ±2.24%
buffers/buffer-from.js n=800000 len=100 source='buffer' *** -1.37 % ±0.72% ±0.95% ±1.24%
buffers/buffer-from.js n=800000 len=100 source='object' -0.60 % ±1.23% ±1.64% ±2.13%
buffers/buffer-from.js n=800000 len=100 source='string-base64' *** 2.41 % ±0.50% ±0.66% ±0.86%
buffers/buffer-from.js n=800000 len=100 source='string-utf8' *** 49.55 % ±0.67% ±0.89% ±1.16%
buffers/buffer-from.js n=800000 len=100 source='string' *** 45.78 % ±0.75% ±1.00% ±1.30%
buffers/buffer-from.js n=800000 len=100 source='uint16array' -0.75 % ±0.75% ±1.00% ±1.30%
buffers/buffer-from.js n=800000 len=100 source='uint8array' *** -3.39 % ±0.77% ±1.03% ±1.36%
buffers/buffer-from.js n=800000 len=2048 source='array' *** -0.25 % ±0.08% ±0.11% ±0.14%
buffers/buffer-from.js n=800000 len=2048 source='arraybuffer-middle' 0.59 % ±1.76% ±2.34% ±3.05%
buffers/buffer-from.js n=800000 len=2048 source='arraybuffer' 0.51 % ±1.62% ±2.16% ±2.81%
buffers/buffer-from.js n=800000 len=2048 source='buffer' * -0.81 % ±0.71% ±0.94% ±1.23%
buffers/buffer-from.js n=800000 len=2048 source='object' -0.22 % ±0.90% ±1.20% ±1.56%
buffers/buffer-from.js n=800000 len=2048 source='string-base64' *** -1.20 % ±0.34% ±0.45% ±0.59%
buffers/buffer-from.js n=800000 len=2048 source='string-utf8' *** -1.18 % ±0.45% ±0.59% ±0.77%
buffers/buffer-from.js n=800000 len=2048 source='string' *** -2.66 % ±0.51% ±0.68% ±0.89%
buffers/buffer-from.js n=800000 len=2048 source='uint16array' *** -1.01 % ±0.52% ±0.69% ±0.91%
buffers/buffer-from.js n=800000 len=2048 source='uint8array' ** -1.23 % ±0.83% ±1.10% ±1.43%

[ronag]

This will get faster once #54311 lands

[codecov]

Codecov Report

Attention: Patch coverage is 89.65517% with 3 lines in your changes missing coverage. Please review.

Project coverage is 87.08%. Comparing base (298ff4f) to head (bfbfd89).
Report is 32 commits behind head on main.

Files	Patch %	Lines
lib/buffer.js	89.65%	2 Missing and 1 partial ⚠️

Additional details and impacted files

@@ Coverage Diff @@## main #54324 +/- ##
==========================================
- Coverage 87.09% 87.08% -0.02% 
==========================================
Files 647 647 Lines 181816 181926 +110 Branches 34884 34898 +14 ==========================================
+ Hits 158360 158428 +68 - Misses 16764 16796 +32 - Partials 6692 6702 +10 

Files	Coverage Δ
src/node_buffer.cc	71.75% <ø> (-3.44%)	⬇️
lib/buffer.js	96.67% <89.65%> (+0.25%)	⬆️

... and 45 files with indirect coverage changes

[ronag]

Benchmark CI: https://ci.nodejs.org/view/Node.js%20benchmark/job/benchmark-node-micro-benchmarks/1600/

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/61052/

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/61084/

[nodejs-github-bot]

✅ CI: https://ci.nodejs.org/job/node-test-pull-request/61095/

[nodejs-github-bot]

Commit Queue failed

- Loading data for nodejs/node/pull/54324
✔ Done loading data for nodejs/node/pull/54324
----------------------------------- PR info ------------------------------------
Title buffer: optimize createFromString (#54324)
Author Robert Nagy <ronagy@icloud.com> (@ronag)
Branch ronag:rm-createFromString -> nodejs:main
Labels buffer, c++, notable-change, author ready, needs-ci
Commits 1
- buffer: optimize createFromString
Committers 1
- Robert Nagy <ronagy@icloud.com>
PR-URL: https://github.com/nodejs/node/pull/54324
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/54324
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
--------------------------------------------------------------------------------
⚠ Commits were pushed since the last approving review:
⚠ - buffer: optimize createFromString
ℹ This PR was created on Mon, 12 Aug 2024 06:05:02 GMT
✔ Approvals: 1
✔ - Yagiz Nizipli (@anonrig) (TSC): https://github.com/nodejs/node/pull/54324#pullrequestreview-2232835571
✘ This PR needs to wait 118 more hours to land (or 0 hours if there is one more approval)
✔ Last GitHub CI successful
ℹ Last Benchmark CI on 2024-08-12T11:10:02Z: https://ci.nodejs.org/view/Node.js%20benchmark/job/benchmark-node-micro-benchmarks/1600/
ℹ Last Full PR CI on 2024-08-14T05:54:06Z: https://ci.nodejs.org/job/node-test-pull-request/61095/
- Querying data for job/node-test-pull-request/61095/
✔ Last Jenkins CI successful
--------------------------------------------------------------------------------
✔ Aborted `git node land` session in /home/runner/work/node/node/.ncu

https://github.com/nodejs/node/actions/runs/10383640109

[mcollina]

lgtm

[nodejs-github-bot]

Landed in 9f08320