Uh oh!
There was an error while loading. Please reload this page.
src: shift even moar x509 to ncrypto - #54340
Closed
jasnell wants to merge 3 commits into
Closed
Conversation
nodejs-github-bot
commented
Aug 12, 2024
Collaborator
Review requested:
|
This comment was marked as outdated.
This comment was marked as outdated.
anonrig
approved these changes
Aug 12, 2024
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
jasnellforce-pushed
the
use-ncrypto-moar-2
branch
from
August 13, 2024 16:36
c746002 to
f2ef1b2Comparejasnellforce-pushed
the
use-ncrypto-moar-2
branch
from
August 13, 2024 16:49
f2ef1b2 to
74c6839Compare
This comment was marked as outdated.
This comment was marked as outdated.
Collaborator
This comment was marked as outdated.
This comment was marked as outdated.
jasnell added a commit
that referenced
this pull request
Aug 14, 2024
PR-URL: #54340 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
jasnell
commented
Aug 14, 2024
MemberAuthor
Landed in 6261187 |
MoLow
commented
Aug 16, 2024
Member
@jasnell nitpic the commit has a typo. moar->more |
RafaelGSS pushed a commit
that referenced
this pull request
Aug 19, 2024
PR-URL: #54340 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Merged
RafaelGSS pushed a commit
that referenced
this pull request
Aug 21, 2024
PR-URL: #54340 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
npaun pushed a commit
to npaun/ncrypto
that referenced
this pull request
Sep 18, 2025
PR-URL: nodejs/node#54340 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@nodejs/crypto @nodejs/cpp-reviewers