Skip to content

buffer: properly apply dst offset and src length on fast path - #54391

Merged
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
nxtedition:fast-string-missing-offset
Aug 15, 2024
Merged

buffer: properly apply dst offset and src length on fast path#54391
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
nxtedition:fast-string-missing-offset

Conversation

@ronag

@ronagronag commented Aug 15, 2024

Copy link
Copy Markdown
Member

No description provided.

@ronagronag added the buffer Issues and PRs related to the buffer subsystem. label Aug 15, 2024
@nodejs-github-botnodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. labels Aug 15, 2024
@ronag

ronag commented Aug 15, 2024

Copy link
Copy Markdown
MemberAuthor

@targos@anonrig Is there a way to force our tests to call fast API? Not sure why our existing tests didn't catch this. Nor how to make them catch this.

@ronagronag changed the title buffer: Properly apply offset on fast pathbuffer: properly apply offset on fast pathAug 15, 2024
@ronag

This comment was marked as resolved.

Sign in to view
@ronag
ronagforce-pushed the fast-string-missing-offset branch from e708a48 to 41c2d89CompareAugust 15, 2024 06:20
@ronag
ronagforce-pushed the fast-string-missing-offset branch 2 times, most recently from f0ba68b to ea45c6cCompareAugust 15, 2024 06:25
@ronag
ronagforce-pushed the fast-string-missing-offset branch from ea45c6c to 9795353CompareAugust 15, 2024 06:26
@ronag
ronagforce-pushed the fast-string-missing-offset branch from 9795353 to bbafef7CompareAugust 15, 2024 06:28
@ronagronag changed the title buffer: properly apply offset on fast pathbuffer: properly apply dst offset and src length on fast pathAug 15, 2024
@ronagronag added the fast-track PRs that do not need to wait for 48 hours to land. label Aug 15, 2024
@github-actions

github-actionsBot commented Aug 15, 2024

Copy link
Copy Markdown
Contributor

Fast-track has been requested by @ronag. Please 👍 to approve.

@ronag
ronag requested a review from benjamingrAugust 15, 2024 06:29
@ronagronag added the request-ci Add this label to start a Jenkins CI on a PR. label Aug 15, 2024
@github-actionsgithub-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Aug 15, 2024
@nodejs-github-bot

nodejs-github-bot commented Aug 15, 2024

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/61127/

@codecov

codecovBot commented Aug 15, 2024•
edited
Loading

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.08%. Comparing base (ccf05ef) to head (bbafef7).
Report is 391 commits behind head on main.

Additional details and impacted files
@@ Coverage Diff @@## main #54391 +/- ##
==========================================
+ Coverage 86.33% 87.08% +0.74% 
==========================================
Files 648 648 Lines 182290 182310 +20 Branches 34812 34985 +173 ==========================================
+ Hits 157385 158757 +1372 + Misses 18213 16822 -1391 - Partials 6692 6731 +39
Files with missing linesCoverage Δ
src/node_buffer.cc70.64% <100.00%> (+0.03%)⬆️

... and 98 files with indirect coverage changes

@nodejs-github-bot

nodejs-github-bot commented Aug 15, 2024

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/61130/

@nodejs-github-bot

nodejs-github-bot commented Aug 15, 2024

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/61131/

@ronagronag added the commit-queue Add this label to land a pull request using GitHub Actions. label Aug 15, 2024
@nodejs-github-bot

nodejs-github-bot commented Aug 15, 2024

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/61134/

@nodejs-github-bot

nodejs-github-bot commented Aug 15, 2024

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/61137/

@nodejs-github-botnodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Aug 15, 2024
@nodejs-github-bot
nodejs-github-bot merged commit 2c14615 into nodejs:mainAug 15, 2024
@nodejs-github-bot

nodejs-github-bot commented Aug 15, 2024

Copy link
Copy Markdown
Collaborator

Landed in 2c14615

@richardlaurichardlau mentioned this pull request Aug 15, 2024
Closed
@avivkelleravivkeller mentioned this pull request Aug 15, 2024
Closed
RafaelGSS pushed a commit that referenced this pull request Aug 19, 2024
@ronag@RafaelGSS
buffer: properly apply dst offset and src length on fast path
7800893
Refs: #54311 (comment)
PR-URL: #54391
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Jake Yuesong Li <jake.yuesong@gmail.com>
@RafaelGSSRafaelGSS mentioned this pull request Aug 19, 2024
Merged
RafaelGSS pushed a commit that referenced this pull request Aug 21, 2024
@ronag@RafaelGSS
buffer: properly apply dst offset and src length on fast path
8ba53ae
Refs: #54311 (comment)
PR-URL: #54391
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Jake Yuesong Li <jake.yuesong@gmail.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@benjamingrbenjamingrbenjamingr approved these changes
@anonriganonriganonrig approved these changes
@jakecastellijakecastellijakecastelli approved these changes
@santigimenosantigimenoAwaiting requested review from santigimeno

Assignees

No one assigned

Labels

bufferIssues and PRs related to the buffer subsystem.c++Issues and PRs that require attention from people who are familiar with C++.fast-trackPRs that do not need to wait for 48 hours to land.needs-ciPRs that need a full CI run.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@ronag@nodejs-github-bot@benjamingr@anonrig@jakecastelli@targos