Uh oh!
There was an error while loading. Please reload this page.
[v22.x backport] doc: reserve ABI 130 for Electron 33 - #54455
Closed
clavin wants to merge 1 commit into
Closed
Conversation
avivkeller
commented
Aug 19, 2024
Member
I'm not sure whether the branch to target should be |
clavin
commented
Aug 19, 2024
ContributorAuthor
Found some docs about it and it looks like I need to potentially reformat my commit & indeed target |
clavinforce-pushed
the
clavin/doc-electron-33-abi-for-v22
branch
from
August 19, 2024 16:02
26ab808 to
a574bd5Compareclavinforce-pushed
the
clavin/doc-electron-33-abi-for-v22
branch
from
August 19, 2024 16:04
a574bd5 to
2013511Compareclavin
commented
Aug 19, 2024
ContributorAuthor
👍 Alright, everything seems to be formatted properly now. I added the |
Backport-PR-URL: nodejs#54455 PR-URL: nodejs#54383 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Jake Yuesong Li <jake.yuesong@gmail.com>
clavinforce-pushed
the
clavin/doc-electron-33-abi-for-v22
branch
from
August 22, 2024 19:29
2013511 to
a319641Compareclavin
commented
Aug 22, 2024
ContributorAuthor
|
RafaelGSS
approved these changes
Aug 24, 2024
RafaelGSS pushed a commit
that referenced
this pull request
Aug 24, 2024
Backport-PR-URL: #54455 PR-URL: #54383 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Jake Yuesong Li <jake.yuesong@gmail.com>
RafaelGSS
commented
Aug 24, 2024
Member
Landed in 83b5efe |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Manual backport of #54383 to
v22.x.