Uh oh!
There was an error while loading. Please reload this page.
Corrected typo in name of "msg" argument in documentation. - #5449
Closed
chrisdew wants to merge 1 commit into
Closed
Corrected typo in name of "msg" argument in documentation.#5449chrisdew wants to merge 1 commit into
chrisdew wants to merge 1 commit into
Conversation
Corrected name of "msg" argument from "buf" to "msg".
evanlucas
commented
Feb 26, 2016
Contributor
LGTM. Can you please update the commit message to match the guidelines in https://github.com/nodejs/node/blob/master/CONTRIBUTING.md#step-3-commit? Specifically, the prefix here should be doc:. Thanks for the contribution!! |
cjihrig
commented
Feb 26, 2016
Contributor
LGTM |
silverwind
commented
Feb 27, 2016
Contributor
LGTM. Landed in 1913909 with a fixed commit message. |
silverwind pushed a commit
that referenced
this pull request
Feb 27, 2016
Corrected name of "msg" argument from "buf" to "msg". PR-URL: #5449 Reviewed-By: Evan Lucas <evanlucas@me.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Roman Reiss <me@silverwind.io>
rvagg pushed a commit
that referenced
this pull request
Feb 28, 2016
Corrected name of "msg" argument from "buf" to "msg". PR-URL: #5449 Reviewed-By: Evan Lucas <evanlucas@me.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Roman Reiss <me@silverwind.io>
jasnell
commented
Mar 2, 2016
Member
Added the lts-watch label... |
MylesBorins
commented
Mar 17, 2016
Contributor
this is not applicable to LTS |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request check-list
Please make sure to review and check all of these items:
make -j8 test(UNIX) orvcbuild test nosign(Windows) pass withthis change (including linting)?
test (or a benchmark) included?
existing APIs, or introduces new ones)?
NOTE: these things are not required to open a PR and can be done
afterwards / while the PR is open.
Affected core subsystem(s)
Please provide affected core subsystem(s) (like buffer, cluster, crypto, etc)
Description of change
Please provide a description of the change here.
Corrected name of "msg" argument from "buf" to "msg".