Skip to content

tls: wrap ssl errors in ECONNRESET - #54492

Open
Uzlopak wants to merge 1 commit into
nodejs:mainfrom
Uzlopak:tls-wrap
Open

tls: wrap ssl errors in ECONNRESET#54492
Uzlopak wants to merge 1 commit into
nodejs:mainfrom
Uzlopak:tls-wrap

Conversation

@Uzlopak

Copy link
Copy Markdown
Contributor

For discussion.

I think we should not break userland, by passing the OpenSSL Errors directly to userland. IMHO they need to be wrapped accordingly.

This PR is not passing all tests and is for demonstration purposes.

Especially notifying:
@mcollina
@RafaelGSS
@nodejs/undici

@nodejs-github-botnodejs-github-bot added errors Issues and PRs related to JavaScript errors originated in Node.js core. needs-ci PRs that need a full CI run. tls Issues and PRs related to the tls subsystem. labels Aug 22, 2024
@UzlopakUzlopak mentioned this pull request Aug 22, 2024
@codecov

codecovBot commented Aug 22, 2024

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 87.33%. Comparing base (7c76fa0) to head (be1f3f9).
⚠️ Report is 5467 commits behind head on main.

Additional details and impacted files
@@ Coverage Diff @@## main #54492 +/- ##
==========================================
+ Coverage 87.31% 87.33% +0.01% 
==========================================
Files 648 649 +1 Lines 182359 182530 +171 Branches 34979 35028 +49 ==========================================
+ Hits 159235 159411 +176 + Misses 16389 16381 -8 - Partials 6735 6738 +3 
Files with missing linesCoverage Δ
lib/_tls_wrap.js93.37% <100.00%> (-0.02%)⬇️
lib/internal/errors.js94.44% <100.00%> (ø)

... and 37 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions

Copy link
Copy Markdown
Contributor

This pull request has been marked as stale due to 90 days of inactivity.
It will be automatically closed in 30 days if no further activity occurs. If this is still relevant, please leave a comment or update it to keep it open.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

errorsIssues and PRs related to JavaScript errors originated in Node.js core.needs-ciPRs that need a full CI run.staletlsIssues and PRs related to the tls subsystem.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@Uzlopak@nodejs-github-bot