Uh oh!
There was an error while loading. Please reload this page.
url: update encodePathChars to handle special characters properly - #54516
Closed
injunchoi98 wants to merge 1 commit into
Closed
url: update encodePathChars to handle special characters properly#54516injunchoi98 wants to merge 1 commit into
injunchoi98 wants to merge 1 commit into
Conversation
nodejs-github-bot
commented
Aug 23, 2024
Collaborator
Review requested:
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@## main #54516 +/- ##
=======================================
Coverage 87.34% 87.34% =======================================
Files 649 649 Lines 182524 182533 +9 Branches 35026 35033 +7 =======================================
+ Hits 159420 159430 +10 + Misses 16373 16372 -1
Partials 6731 6731
|
Contributor
I'm not sure it's worth changing, in what scenario those char can be problematic in the path? EDIT: the answer is in #54515 (comment) |
avivkeller
commented
Aug 25, 2024
Member
Can this be closed in favor of @aduh95's PR? |
injunchoi98
commented
Aug 25, 2024
ContributorAuthor
Of course! Thank you for let me know |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes#54515