Skip to content

test: retry on known SmartOS bug - #5454

Closed
Trott wants to merge 1 commit into
nodejs:masterfrom
Trott:fix-fix-fix
Closed

test: retry on known SmartOS bug#5454
Trott wants to merge 1 commit into
nodejs:masterfrom
Trott:fix-fix-fix

Conversation

@Trott

@TrottTrott commented Feb 26, 2016

Copy link
Copy Markdown
Member

There is a known issue with SmartOS that is generally worked around
in tools/test.py. However, a more robust workaround is required for
some tests that open many network connections.

test-http-regr-gh-2928 is one such test.

Fixes: #5445
Refs: #3941

@TrottTrott added http Issues or PRs related to the http subsystem. test Issues and PRs related to the tests. smartos Issues and PRs related to the SmartOS platform. labels Feb 26, 2016
@Trott

Trott commented Feb 26, 2016

Copy link
Copy Markdown
MemberAuthor

Stress test for this version of the test, expected to show zero failures: https://ci.nodejs.org/job/node-stress-single-test/545/nodes=smartos14-32/console

Stress test for current version on master, showing failures: https://ci.nodejs.org/job/node-stress-single-test/528/nodes=smartos14-32/console

@Trott

Trott commented Feb 26, 2016

Copy link
Copy Markdown
MemberAuthor

CI: https://ci.nodejs.org/job/node-test-pull-request/1762/

@santigimeno

santigimeno commented Feb 26, 2016

Copy link
Copy Markdown
Member

There is a known issue with SmartOS that is generally worked around
in tools/test.py

How is it done?

@Trott

Trott commented Feb 26, 2016

Copy link
Copy Markdown
MemberAuthor

@santigimeno wrote:

There is a known issue with SmartOS that is generally worked around
in tools/test.py

How is it done?

See 8bc8038 and #3941

@Trott

Trott commented Feb 28, 2016

Copy link
Copy Markdown
MemberAuthor

/cc @nodejs/testing

@Trott

Trott commented Feb 28, 2016

Copy link
Copy Markdown
MemberAuthor

CI again: https://ci.nodejs.org/job/node-test-pull-request/1771/

@Trott

Trott commented Feb 29, 2016

Copy link
Copy Markdown
MemberAuthor

Bump. @nodejs/collaborators

@Trott

Trott commented Mar 1, 2016

Copy link
Copy Markdown
MemberAuthor

Still fishing for an LGTM on this from an onboarded collaborator.

Maybe @mscdexwho reported the problem?

Or @jasnellwho LGTMed a similar fix in another test?

Or @indutnywho reviewed a PR for a more generalized fix that helps other tests but not necessarily ones with lots of connections like this one?

@indutny

indutny commented Mar 1, 2016

Copy link
Copy Markdown
Member

Why doesn't more generalized fix do not help here?

indutny
indutny reviewed Mar 1, 2016
View reviewed changes
Comment threadtest/sequential/test-http-regr-gh-2928.js Outdated

@indutnyindutnyMar 1, 2016

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please skip additional parens here.

@TrottTrottMar 1, 2016

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please skip additional parens here.

Additional parens removed, branch rebased, force pushed. Will run CI one more time.

There's a build-in lint rule to catch extra parentheses, Alas, enabling it flags 315 instances in the code base. Probably not worth the churn. I might look more closely at it, though...

@indutny

indutny commented Mar 1, 2016

Copy link
Copy Markdown
Member

Anyway, if it helps - LGTM

@Trott

Trott commented Mar 1, 2016

Copy link
Copy Markdown
MemberAuthor

@indutny asked:

Why doesn't more generalized fix do not help here?

The more generalized fix retries the test one time if it's SmartOS and failed due to ECONNREFUSED. That works well for tests that open just a few connections because the bug seems to crop up once every few hundred connections or so.

However, for tests that open dozens or hundreds of connections, one retry may not be enough. So, for this and for one other test, we ignore ECONNREFUSED on SmartOS and try the connection again within the test itself.

@Trott
test: retry on known SmartOS bug
bb388bc
There is a known issue with SmartOS that is generally worked around
in `tools/test.py`. However, a more robust workaround is required for
some tests that open many network connections.
`test-http-regr-nodejsgh-2928` is one such test.
Fixes: nodejs#5445
Refs: nodejs#3941
PR-URL: nodejs#5454
@Trott

Trott commented Mar 1, 2016

Copy link
Copy Markdown
MemberAuthor

Hopefully gratuitous CI: https://ci.nodejs.org/job/node-test-pull-request/1796/

Trott added a commit to Trott/io.js that referenced this pull request Mar 1, 2016
@Trott
test: retry on known SmartOS bug
8592697
There is a known issue with SmartOS that is generally worked around
in `tools/test.py`. However, a more robust workaround is required for
some tests that open many network connections.
`test-http-regr-nodejsgh-2928` is one such test.
Fixes: nodejs#5445
Refs: nodejs#3941
PR-URL: nodejs#5454
Reviewed-By: Fedor Indutny <fedor@indutny.com>
@Trott

Trott commented Mar 1, 2016

Copy link
Copy Markdown
MemberAuthor

Landed in 8592697

@TrottTrott closed this Mar 1, 2016
Fishrock123 pushed a commit that referenced this pull request Mar 2, 2016
@Trott@Fishrock123
test: retry on known SmartOS bug
d1a82c6
There is a known issue with SmartOS that is generally worked around
in `tools/test.py`. However, a more robust workaround is required for
some tests that open many network connections.
`test-http-regr-gh-2928` is one such test.
Fixes: #5445
Refs: #3941
PR-URL: #5454
Reviewed-By: Fedor Indutny <fedor@indutny.com>
MylesBorins pushed a commit that referenced this pull request Mar 17, 2016
@TrottMyles Borins
test: retry on known SmartOS bug
7c0fc04
There is a known issue with SmartOS that is generally worked around
in `tools/test.py`. However, a more robust workaround is required for
some tests that open many network connections.
`test-http-regr-gh-2928` is one such test.
Fixes: #5445
Refs: #3941
PR-URL: #5454
Reviewed-By: Fedor Indutny <fedor@indutny.com>
MylesBorins pushed a commit that referenced this pull request Mar 21, 2016
@TrottMyles Borins
test: retry on known SmartOS bug
b4ef644
There is a known issue with SmartOS that is generally worked around
in `tools/test.py`. However, a more robust workaround is required for
some tests that open many network connections.
`test-http-regr-gh-2928` is one such test.
Fixes: #5445
Refs: #3941
PR-URL: #5454
Reviewed-By: Fedor Indutny <fedor@indutny.com>
Trott added a commit to Trott/io.js that referenced this pull request May 3, 2016
@Trott
test: unmark test-http-regr-nodejsgh-2928as flaky
01f60a0
The flakiness issue for test-http-regr-nodejsgh-2928 on SmartOS was resolved
in late February in nodejs#5454. This
change removes its flaky designation in sequential.status.
@TrottTrott mentioned this pull request May 3, 2016
Closed
2 tasks
Trott added a commit to Trott/io.js that referenced this pull request May 5, 2016
@Trott
test: unmark test-http-regr-nodejsgh-2928as flaky
330ea76
The flakiness issue for test-http-regr-nodejsgh-2928 on SmartOS was resolved
in late February in nodejs#5454. This
change removes its flaky designation in sequential.status.
PR-URL: nodejs#6540
Reviewed-By: James M Snell <jasnell@gmail.com>
evanlucas pushed a commit that referenced this pull request May 17, 2016
@Trott@evanlucas
test: unmark test-http-regr-gh-2928as flaky
8c434e6
The flakiness issue for test-http-regr-gh-2928 on SmartOS was resolved
in late February in #5454. This
change removes its flaky designation in sequential.status.
PR-URL: #6540
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit that referenced this pull request Jul 11, 2016
@TrottMyles Borins
test: unmark test-http-regr-gh-2928as flaky
a27439a
The flakiness issue for test-http-regr-gh-2928 on SmartOS was resolved
in late February in #5454. This
change removes its flaky designation in sequential.status.
PR-URL: #6540
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit that referenced this pull request Jul 11, 2016
@TrottMyles Borins
test: unmark test-http-regr-gh-2928as flaky
34b61d6
The flakiness issue for test-http-regr-gh-2928 on SmartOS was resolved
in late February in #5454. This
change removes its flaky designation in sequential.status.
PR-URL: #6540
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit that referenced this pull request Jul 12, 2016
@Trott@MylesBorins
test: unmark test-http-regr-gh-2928as flaky
c1b62eb
The flakiness issue for test-http-regr-gh-2928 on SmartOS was resolved
in late February in #5454. This
change removes its flaky designation in sequential.status.
PR-URL: #6540
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit that referenced this pull request Jul 12, 2016
@TrottMyles Borins
test: unmark test-http-regr-gh-2928as flaky
9e8addd
The flakiness issue for test-http-regr-gh-2928 on SmartOS was resolved
in late February in #5454. This
change removes its flaky designation in sequential.status.
PR-URL: #6540
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit that referenced this pull request Jul 14, 2016
@TrottMyles Borins
test: unmark test-http-regr-gh-2928as flaky
39fbc18
The flakiness issue for test-http-regr-gh-2928 on SmartOS was resolved
in late February in #5454. This
change removes its flaky designation in sequential.status.
PR-URL: #6540
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit that referenced this pull request Jul 14, 2016
@TrottMyles Borins
test: unmark test-http-regr-gh-2928as flaky
3aef9b8
The flakiness issue for test-http-regr-gh-2928 on SmartOS was resolved
in late February in #5454. This
change removes its flaky designation in sequential.status.
PR-URL: #6540
Reviewed-By: James M Snell <jasnell@gmail.com>
@Trott
Trott deleted the fix-fix-fix branch January 13, 2022 22:42
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

httpIssues or PRs related to the http subsystem.smartosIssues and PRs related to the SmartOS platform.testIssues and PRs related to the tests.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Trott@santigimeno@indutny@MylesBorins