Skip to content

test: use valid hostnames - #54556

Merged
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
lpinca:use/valid-hostnames
Aug 25, 2024
Merged

test: use valid hostnames#54556
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
lpinca:use/valid-hostnames

Conversation

@lpinca

@lpincalpinca commented Aug 25, 2024

Copy link
Copy Markdown
Member

Use valid hostnames in
test/sequential/test-net-server-listen-ipv6-link-local.js.

Refs: #54554

@lpinca
test: use valid hostnames
2d7aee7
Use valid hostnames in
`test/sequential/test-net-server-listen-ipv6-link-local.js`.
Refs: nodejs#54554
@nodejs-github-botnodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Aug 25, 2024
@codecov

codecovBot commented Aug 25, 2024•
edited
Loading

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.33%. Comparing base (7fea010) to head (2d7aee7).
Report is 326 commits behind head on main.

Additional details and impacted files
@@ Coverage Diff @@## main #54556 +/- ##
=======================================
Coverage 87.32% 87.33% =======================================
Files 649 649 Lines 182618 182626 +8 Branches 35033 35043 +10 =======================================
+ Hits 159475 159489 +14 + Misses 16407 16402 -5 + Partials 6736 6735 -1

see 21 files with indirect coverage changes

@lpincalpinca added the request-ci Add this label to start a Jenkins CI on a PR. label Aug 25, 2024
@github-actionsgithub-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Aug 25, 2024
@nodejs-github-bot

nodejs-github-bot commented Aug 25, 2024

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/61456/

@avivkeller

avivkeller commented Aug 25, 2024

Copy link
Copy Markdown
Member

This issue was causing test failures left and right, should this be fast tracked?

@avivkelleravivkeller mentioned this pull request Aug 25, 2024
Closed
@nodejs-github-bot

nodejs-github-bot commented Aug 25, 2024

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/61458/

@anonriganonrig added the fast-track PRs that do not need to wait for 48 hours to land. label Aug 25, 2024
@github-actions

github-actionsBot commented Aug 25, 2024

Copy link
Copy Markdown
Contributor

Fast-track has been requested by @anonrig. Please 👍 to approve.

@anonriganonrig added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Aug 25, 2024
@anonrig
anonrig requested a review from jasnellAugust 25, 2024 20:34
@avivkelleravivkeller mentioned this pull request Aug 25, 2024
Merged
@nodejs-github-bot

nodejs-github-bot commented Aug 25, 2024

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/61460/

@aduh95aduh95 added the commit-queue Add this label to land a pull request using GitHub Actions. label Aug 25, 2024
@nodejs-github-botnodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Aug 25, 2024
@nodejs-github-bot
nodejs-github-bot merged commit 1399d4e into nodejs:mainAug 25, 2024
@nodejs-github-bot

nodejs-github-bot commented Aug 25, 2024

Copy link
Copy Markdown
Collaborator

Landed in 1399d4e

@lpinca
lpinca deleted the use/valid-hostnames branch August 26, 2024 05:08
@joyeecheungjoyeecheung mentioned this pull request Aug 26, 2024
Closed
RafaelGSS pushed a commit that referenced this pull request Aug 30, 2024
@lpinca@RafaelGSS
test: use valid hostnames
66ae9f4
Use valid hostnames in
`test/sequential/test-net-server-listen-ipv6-link-local.js`.
Refs: #54554
PR-URL: #54556
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
@RafaelGSSRafaelGSS mentioned this pull request Aug 30, 2024
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@anonriganonriganonrig approved these changes
@aduh95aduh95aduh95 approved these changes
@jasnelljasnellAwaiting requested review from jasnell

Assignees

No one assigned

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.fast-trackPRs that do not need to wait for 48 hours to land.needs-ciPRs that need a full CI run.testIssues and PRs related to the tests.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@lpinca@nodejs-github-bot@avivkeller@anonrig@aduh95@targos