src: disable fast methods for `buffer.write` by targos · Pull Request #54565 · nodejs/node

targos · 2024-08-26T06:07:46Z

It should resolve the regressions while we work on fixing them.

Refs: #54521

It should resolve the regressions while we work on fixing them. Refs: nodejs#54521

codecov · 2024-08-26T07:48:35Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.33%. Comparing base (1399d4e) to head (a7a10a7).
Report is 323 commits behind head on main.

Additional details and impacted files

@@ Coverage Diff @@## main #54565 +/- ##
==========================================
- Coverage 87.33% 87.33% -0.01% 
==========================================
Files 649 649 Lines 182626 182620 -6 Branches 35041 35040 -1 ==========================================
- Hits 159503 159489 -14 - Misses 16394 16404 +10 + Partials 6729 6727 -2

Files with missing lines	Coverage Δ
src/node_buffer.cc	`69.94% <100.00%> (-0.71%)`	⬇️

... and 23 files with indirect coverage changes

targos · 2024-08-26T07:54:30Z

If this is accepted, it should be fast-tracked for inclusion in #54560

github-actions · 2024-08-26T07:54:44Z

Fast-track has been requested by @targos. Please 👍 to approve.

benjamingr · 2024-08-26T10:44:59Z

@bricss please do not approve fast-track requests :] (or you know, start making PRs and join as a collaborator that also works :))

nodejs-github-bot · 2024-08-26T12:41:48Z

CI: https://ci.nodejs.org/job/node-test-pull-request/61482/

nodejs-github-bot · 2024-08-26T13:08:43Z

CI: https://ci.nodejs.org/job/node-test-pull-request/61487/

nodejs-github-bot · 2024-08-26T18:42:14Z

CI: https://ci.nodejs.org/job/node-test-pull-request/61509/

nodejs-github-bot · 2024-08-27T03:57:37Z

CI: https://ci.nodejs.org/job/node-test-pull-request/61524/

ronag · 2024-08-27T04:00:17Z

@targos can you fix commit msg (PR-URL)?

jasnell · 2024-08-27T15:48:07Z

- "utf8WriteStatic",
- SlowWriteString<UTF8>,
- &fast_write_string);
+ SetMethod(context, target, "asciiWriteStatic", SlowWriteString<ASCII>);


non-blocking nit: perhaps consider adding a TODO comment?

targos · 2024-08-27T15:48:39Z

@ronag I don't see a problem in the commit message.

nodejs-github-bot · 2024-08-27T16:39:48Z

CI: https://ci.nodejs.org/job/node-test-pull-request/61563/

nodejs-github-bot · 2024-08-27T19:03:08Z

CI: https://ci.nodejs.org/job/node-test-pull-request/61569/

nodejs-github-bot · 2024-08-27T21:15:33Z

CI: https://ci.nodejs.org/job/node-test-pull-request/61571/

nodejs-github-bot · 2024-08-28T13:02:31Z

CI: https://ci.nodejs.org/job/node-test-pull-request/61586/

ronag · 2024-08-28T13:03:31Z

@ronag I don't see a problem in the commit message.

@targos

Commit message must match a given regex pattern: PR-URL: https://github\.com/(nodejs|nodejs-private)/(node|node-private)/pull/\d+

targos · 2024-08-28T13:08:11Z

This message appears (to collaborators) on all the pull requests of the project. Unfortunately there is no way to customize it but the goal is to prevent merging by accident using the GitHub UI.

nodejs-github-bot · 2024-08-28T15:12:49Z

CI: https://ci.nodejs.org/job/node-test-pull-request/61593/

nodejs-github-bot · 2024-08-28T19:40:23Z

CI: https://ci.nodejs.org/job/node-test-pull-request/61601/

nodejs-github-bot · 2024-08-28T23:29:22Z

CI: https://ci.nodejs.org/job/node-test-pull-request/61616/

nodejs-github-bot · 2024-08-29T07:06:41Z

Landed in 7616855

It should resolve the regressions while we work on fixing them. Refs: #54521 PR-URL: #54565 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Robert Nagy <ronagy@icloud.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com>

Now that Node.js 22.8 is available with a workaround (nodejs/node#54565) for the bug in 22.7 that caused 'RangeError: "length" is outside of buffer bounds' errors in exporter tests (see open-telemetry#4953), we can unpin the Node.js v22 used for unit tests. This undoes the pinning from open-telemetry#4957.

src: disable fast methods for buffer.write
a7a10a7
It should resolve the regressions while we work on fixing them. Refs: nodejs#54521

nodejs-github-bot added buffer Issues and PRs related to the buffer subsystem. c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. labels Aug 26, 2024

targos mentioned this pull request Aug 26, 2024
v22.8.0 proposal #54560
Merged

targos added the fast-track PRs that do not need to wait for 48 hours to land. label Aug 26, 2024

benjamingr approved these changes Aug 26, 2024
View reviewed changes

ronag approved these changes Aug 26, 2024
View reviewed changes

targos added the request-ci Add this label to start a Jenkins CI on a PR. label Aug 26, 2024

github-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Aug 26, 2024

lpinca approved these changes Aug 26, 2024
View reviewed changes

anonrig approved these changes Aug 26, 2024
View reviewed changes

ronag added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels Aug 26, 2024

github-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Aug 26, 2024

addaleax approved these changes Aug 26, 2024
View reviewed changes

avivkeller mentioned this pull request Aug 26, 2024
SWC + next.js + Node.js v22.7 #54532
Closed

avivkeller mentioned this pull request Aug 27, 2024
UTF+8 encodings are broken #54543
Closed

jasnell approved these changes Aug 27, 2024
View reviewed changes

jasnell reviewed Aug 27, 2024
View reviewed changes

lpinca added the commit-queue Add this label to land a pull request using GitHub Actions. label Aug 29, 2024

nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Aug 29, 2024

nodejs-github-bot merged commit 7616855 into nodejs:mainAug 29, 2024

targos deleted the buffer-fast-write-disable branch August 29, 2024 07:24

avivkeller mentioned this pull request Aug 29, 2024
Buffer.from() output breaks after optimizing in nodejs 22.7 #54521
Closed

emilazy mentioned this pull request Sep 3, 2024
nodejs_22: 22.6.0 -> 22.7.0 NixOS/nixpkgs#336556
Merged
13 tasks

trentm mentioned this pull request Sep 4, 2024
chore: unpin unit-test from 22.6 open-telemetry/opentelemetry-js#4977
Merged

targos added the dont-land-on-v20.x label Sep 22, 2024

Uh oh!

Uh oh!

Conversation

targos commented Aug 26, 2024

Uh oh!

codecovBot commented Aug 26, 2024• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

targos commented Aug 26, 2024

Uh oh!

github-actionsBot commented Aug 26, 2024

Uh oh!

benjamingr commented Aug 26, 2024

Uh oh!

nodejs-github-bot commented Aug 26, 2024

Uh oh!

nodejs-github-bot commented Aug 26, 2024

Uh oh!

nodejs-github-bot commented Aug 26, 2024

Uh oh!

nodejs-github-bot commented Aug 27, 2024

Uh oh!

ronag commented Aug 27, 2024

Uh oh!

jasnellAug 27, 2024

Choose a reason for hiding this comment

Uh oh!

targos commented Aug 27, 2024

Uh oh!

nodejs-github-bot commented Aug 27, 2024

Uh oh!

nodejs-github-bot commented Aug 27, 2024

Uh oh!

nodejs-github-bot commented Aug 27, 2024

Uh oh!

nodejs-github-bot commented Aug 28, 2024

Uh oh!

ronag commented Aug 28, 2024• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

targos commented Aug 28, 2024

Uh oh!

nodejs-github-bot commented Aug 28, 2024

Uh oh!

nodejs-github-bot commented Aug 28, 2024

Uh oh!

nodejs-github-bot commented Aug 28, 2024

Uh oh!

nodejs-github-bot commented Aug 29, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

codecovBot commented Aug 26, 2024•
edited
Loading

ronag commented Aug 28, 2024•
edited
Loading