Skip to content

test: refactor test-whatwg-webstreams-encoding to be shorter - #54569

Merged
nodejs-github-bot merged 3 commits into
nodejs:mainfrom
hidaviddong:main
Sep 19, 2024
Merged

test: refactor test-whatwg-webstreams-encoding to be shorter#54569
nodejs-github-bot merged 3 commits into
nodejs:mainfrom
hidaviddong:main

Conversation

@hidaviddong

Copy link
Copy Markdown
Contributor

Use a forEach loop for assert.throws statements, improving code readability.

@nodejs-github-botnodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Aug 26, 2024
@lpinca

Copy link
Copy Markdown
Member

@hidaviddong please remove the merge commit.

@hidaviddong

Copy link
Copy Markdown
ContributorAuthor

@hidaviddong please remove the merge commit.

done

@lpincalpinca added request-ci Add this label to start a Jenkins CI on a PR. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. labels Aug 29, 2024
@github-actionsgithub-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Aug 29, 2024
@nodejs-github-bot

This comment was marked as outdated.

@richardlau

Copy link
Copy Markdown
Member

Use a forEach loop for assert.throws statements, improving code readability.

This will make diagnosing any failures harder as the stack traces will now point to the loop without an indication of which iteration of the loop failed.

@hidaviddong

Copy link
Copy Markdown
ContributorAuthor

Use a forEach loop for assert.throws statements, improving code readability.

This will make diagnosing any failures harder as the stack traces will now point to the loop without an indication of which iteration of the loop failed.

Do I need to add a stack trace? like done in #45146

@richardlau

Copy link
Copy Markdown
Member

Use a forEach loop for assert.throws statements, improving code readability.

This will make diagnosing any failures harder as the stack traces will now point to the loop without an indication of which iteration of the loop failed.

Do I need to add a stack trace? like done in #45146

I think that would work.

@hidaviddonghidaviddong changed the title test: refactor test-whatwg-webstreams-encoding to be shortertest: refactor test-whatwg-webstreams-encoding to be shorterAug 29, 2024
@codecov

codecovBot commented Aug 29, 2024

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.31%. Comparing base (4ce9864) to head (9738074).
Report is 737 commits behind head on main.

Additional details and impacted files
@@ Coverage Diff @@## main #54569 +/- ##
==========================================
- Coverage 87.33% 87.31% -0.03% 
==========================================
Files 649 649 Lines 182623 182755 +132 Branches 35041 35051 +10 ==========================================
+ Hits 159498 159575 +77 - Misses 16400 16452 +52 - Partials 6725 6728 +3 

see 54 files with indirect coverage changes

@richardlaurichardlau added the request-ci Add this label to start a Jenkins CI on a PR. label Aug 29, 2024
@github-actionsgithub-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Aug 29, 2024
@nodejs-github-bot

This comment was marked as outdated.

@nodejs-github-bot

nodejs-github-bot commented Aug 29, 2024

Copy link
Copy Markdown
Collaborator

@hidaviddong

Copy link
Copy Markdown
ContributorAuthor

I see a CI failure, but I'm not sure what caused it. Do I need to change anything?

@jasnelljasnell added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Sep 8, 2024
@richardlaurichardlau added the commit-queue Add this label to land a pull request using GitHub Actions. label Sep 19, 2024
@nodejs-github-botnodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Sep 19, 2024
@nodejs-github-bot
nodejs-github-bot merged commit 291d90a into nodejs:mainSep 19, 2024
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

Landed in 291d90a

targos pushed a commit that referenced this pull request Oct 4, 2024
PR-URL: #54569
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
@aduh95aduh95 mentioned this pull request Oct 9, 2024
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.commit-queue-squashAdd this label to instruct the Commit Queue to squash all the PR commits into the first one.needs-ciPRs that need a full CI run.testIssues and PRs related to the tests.web streams

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants

@hidaviddong@lpinca@nodejs-github-bot@richardlau@jasnell@marco-ippolito@avivkeller