Uh oh!
There was an error while loading. Please reload this page.
test: refactor test-whatwg-webstreams-encoding to be shorter - #54569
Conversation
lpinca
commented
Aug 29, 2024
@hidaviddong please remove the merge commit. |
hidaviddong
commented
Aug 29, 2024
done |
This comment was marked as outdated.
This comment was marked as outdated.
richardlau
commented
Aug 29, 2024
This will make diagnosing any failures harder as the stack traces will now point to the loop without an indication of which iteration of the loop failed. |
hidaviddong
commented
Aug 29, 2024
Do I need to add a stack trace? like done in #45146 |
richardlau
commented
Aug 29, 2024
I think that would work. |
test-whatwg-webstreams-encoding to be shorterCodecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@## main #54569 +/- ##
==========================================
- Coverage 87.33% 87.31% -0.03%
==========================================
Files 649 649 Lines 182623 182755 +132 Branches 35041 35051 +10 ==========================================
+ Hits 159498 159575 +77 - Misses 16400 16452 +52 - Partials 6725 6728 +3 |
This comment was marked as outdated.
This comment was marked as outdated.
hidaviddong
commented
Aug 30, 2024
I see a CI failure, but I'm not sure what caused it. Do I need to change anything? |
nodejs-github-bot
commented
Sep 19, 2024
Landed in 291d90a |
PR-URL: #54569 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com>
Use a
forEachloop forassert.throwsstatements, improving code readability.