Skip to content

test: update test-abortsignal-cloneable to use node:test - #54581

Closed
jasnell wants to merge 1 commit into
nodejs:mainfrom
jasnell:use-test-in-test-abortsignal-cloneable
Closed

test: update test-abortsignal-cloneable to use node:test#54581
jasnell wants to merge 1 commit into
nodejs:mainfrom
jasnell:use-test-in-test-abortsignal-cloneable

Conversation

@jasnell

Copy link
Copy Markdown
Member

No description provided.

@nodejs-github-botnodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Aug 27, 2024
@codecov

This comment was marked as outdated.

@mcollinamcollina left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@jasnelljasnell added the request-ci Add this label to start a Jenkins CI on a PR. label Aug 27, 2024
@github-actionsgithub-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Aug 27, 2024
@nodejs-github-bot

This comment was marked as outdated.

@jasnell

This comment was marked as outdated.

@jasnell
jasnellforce-pushed the use-test-in-test-abortsignal-cloneable branch from 5bbb612 to 71a5123CompareAugust 29, 2024 18:42
@jasnell
jasnellforce-pushed the use-test-in-test-abortsignal-cloneable branch from 71a5123 to ae9c91dCompareAugust 29, 2024 18:54
@nodejs-github-bot

This comment was marked as outdated.

@nodejs-github-bot

nodejs-github-bot commented Aug 29, 2024

Copy link
Copy Markdown
Collaborator

jasnell added a commit that referenced this pull request Aug 29, 2024
PR-URL: #54581
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
@jasnell

Copy link
Copy Markdown
MemberAuthor

Landed in 2bd0f99

@jasnelljasnell closed this Aug 29, 2024
RafaelGSS pushed a commit that referenced this pull request Aug 30, 2024
PR-URL: #54581
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
@RafaelGSSRafaelGSS mentioned this pull request Aug 30, 2024
RafaelGSS pushed a commit that referenced this pull request Sep 1, 2024
PR-URL: #54581
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs-ciPRs that need a full CI run.testIssues and PRs related to the tests.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@jasnell@nodejs-github-bot@mcollina@anonrig@targos