Uh oh!
There was an error while loading. Please reload this page.
test: increase timeout for test-tls-fast-writing - #5466
Conversation
silverwind
commented
Feb 28, 2016
Factor 10 seems a bit much, no? Do CI machines do multiple runs in parallel? |
Trott
commented
Feb 28, 2016
@silverwind asked:
There's no real advantage to "right-sizing" the timeout other than a user waits a second or two less on a failed test at the command line. So I'd rather put in a preposterous increase now and never have to deal with the problem again instead of putting in a modest increase now and needing to put in another modest increase or two in a month.
I don't think they do yet but I believe @jbergstroem is not far from having that implemented. (Or was the switch already flipped on that?) |
jbergstroem
commented
Feb 28, 2016
@Trott still not implemented. |
Trott
commented
Feb 29, 2016
@silverwind If reducing the increase from a factor of 10 to a factor of (say) 2 would make you more comfortable with the change, I'm totally OK with doing that instead. |
silverwind
commented
Feb 29, 2016
My issue is that these tests usually set a performance goal through these timeouts, I think I'd be okay with something more modest like 2x or 3x. |
Increase timeout for test from 500ms to 1000ms so busy slow machines don't produce false positives. Fixes: nodejs#4964
9d71427 to
829339cCompareTrott
commented
Feb 29, 2016
@silverwind OK, changed to 1000ms instead of 5000ms. |
Trott
commented
Mar 1, 2016
CI is green except for one host that failed to finish building. Looks good to anyone? @nodejs/testing |
orangemocha
commented
Mar 2, 2016
LGTM |
Increase timeout for test from 500ms to 1000ms so busy slow machines don't produce false positives. Fixes: nodejs#4964 PR-URL: nodejs#5466 Reviewed-By: Alexis Campailla <orangemocha@nodejs.org>
Trott
commented
Mar 2, 2016
Landed in c133d07 |
Increase timeout for test from 500ms to 5000ms so busy slow machines
don't produce false positives.
Fixes: #4964