Skip to content

path: remove StringPrototypeCharCodeAt from some methods of posix#54668

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
HBSPS wants to merge 1 commit into
base:main
Choose a base branch
from
Open

path: remove StringPrototypeCharCodeAt from some methods of posix#54668

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 6 additions & 9 deletions lib/path.js
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -1262,8 +1262,7 @@ const posix = {
}

resolvedPath = `${path}/${resolvedPath}`;
resolvedAbsolute =
StringPrototypeCharCodeAt(path, 0) === CHAR_FORWARD_SLASH;
resolvedAbsolute = path[0] === '/';
}

if (!resolvedAbsolute) {
Expand DownExpand Up@@ -1296,10 +1295,8 @@ const posix = {
if (path.length === 0)
return '.';

const isAbsolute =
StringPrototypeCharCodeAt(path, 0) === CHAR_FORWARD_SLASH;
const trailingSeparator =
StringPrototypeCharCodeAt(path, path.length - 1) === CHAR_FORWARD_SLASH;
const isAbsolute = path[0] === '/';
const trailingSeparator = path[path.length - 1] === '/';

// Normalize the path
path = normalizeString(path, !isAbsolute, '/', isPosixPathSeparator);
Expand DownExpand Up@@ -1639,8 +1636,8 @@ const posix = {

// Get non-dir info
for (; i >= start; --i) {
const code = StringPrototypeCharCodeAt(path, i);
if (code === CHAR_FORWARD_SLASH) {
const char = path[i];
if (char === '/') {
// If we reached a path separator that was not part of a set of path
// separators at the end of the string, stop now
if (!matchedSlash) {
Expand All@@ -1655,7 +1652,7 @@ const posix = {
matchedSlash = false;
end = i + 1;
}
if (code === CHAR_DOT) {
if (char === '.') {
// If this is our first dot, mark it as the start of our extension
if (startDot === -1)
startDot = i;
Expand Down
Loading