Skip to content

lib: convert signals to array before validation - #54714

Merged
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
jazelly:fix-abort-any
Sep 6, 2024
Merged

lib: convert signals to array before validation#54714
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
jazelly:fix-abort-any

Conversation

@jazelly

@jazellyjazelly commented Sep 2, 2024

Copy link
Copy Markdown
Member

Fixes: #54674

@nodejs-github-bot

nodejs-github-bot commented Sep 2, 2024•
edited by jakecastelli
Loading

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/crypto
  • @nodejs/web-standards

@nodejs-github-botnodejs-github-bot added crypto Issues and PRs related to the crypto subsystem. needs-ci PRs that need a full CI run. labels Sep 2, 2024
@jazellyjazelly changed the title abort_controller: convert signals to array before validationlib: convert signals to array before validationSep 2, 2024
@codecov

codecovBot commented Sep 2, 2024•
edited
Loading

Copy link
Copy Markdown

Codecov Report

Attention: Patch coverage is 90.00000% with 9 lines in your changes missing coverage. Please review.

Project coverage is 87.60%. Comparing base (981c701) to head (80b16d1).
Report is 252 commits behind head on main.

Files with missing linesPatch %Lines
lib/internal/webidl.js88.31%9 Missing ⚠️
Additional details and impacted files
@@ Coverage Diff @@## main #54714 +/- ##
==========================================
- Coverage 87.61% 87.60% -0.01% 
==========================================
Files 650 650 Lines 182835 182881 +46 Branches 35382 35397 +15 ==========================================
+ Hits 160185 160218 +33 - Misses 15925 15930 +5 - Partials 6725 6733 +8
Files with missing linesCoverage Δ
lib/internal/abort_controller.js97.90% <100.00%> (+0.03%)⬆️
lib/internal/crypto/webidl.js98.29% <100.00%> (+0.65%)⬆️
lib/internal/webidl.js94.57% <88.31%> (-1.30%)⬇️

... and 33 files with indirect coverage changes

aduh95
aduh95 reviewed Sep 2, 2024
View reviewed changes
Comment threadlib/internal/abort_controller.js Outdated
jakecastelli
jakecastelli reviewed Sep 2, 2024
View reviewed changes
Comment threadtest/parallel/test-abortsignal-any.mjs Outdated
mcollina
mcollina reviewed Sep 2, 2024
View reviewed changes

@mcollinamcollina left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does this fix any wpts?

@KhafraDev

KhafraDev commented Sep 2, 2024

Copy link
Copy Markdown
Member

the WPTs don't usually test webidl validations because implementations are assumed to be using them for the dozens of specs they implement

mcollina
mcollina approved these changes Sep 2, 2024
View reviewed changes

@mcollinamcollina left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

mertcanaltin
mertcanaltin approved these changes Sep 2, 2024
View reviewed changes

@mertcanaltinmertcanaltin left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

KhafraDev
KhafraDev reviewed Sep 3, 2024
View reviewed changes
Comment threadlib/internal/webidl.js Outdated
@jazelly@jakecastelli
lib: convert signals to array before validation
80b16d1
Co-authored-by: Jake Yuesong Li <jake.yuesong@gmail.com>
@jakecastellijakecastelli added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. web-standards Issues and PRs related to Web APIs labels Sep 3, 2024
@github-actionsgithub-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Sep 3, 2024
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@jakecastelli

jakecastelli commented Sep 3, 2024•
edited
Loading

Copy link
Copy Markdown
Member

osx failure on CI due to java.io.IOException: No space left on device (6h ago) however I also observed nodejs/jenkins-alerts#2785 (10h ago) mentioned The machine has now enough disk space 🙌

Other failures are most likely flaky tests, rerunning

update: rerun works on osx, seems the no space issue has been resolved.

@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@jakecastellijakecastelli added the request-ci Add this label to start a Jenkins CI on a PR. label Sep 4, 2024
@github-actionsgithub-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Sep 4, 2024
@nodejs-github-bot

nodejs-github-bot commented Sep 4, 2024

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/61897/

@nodejs-github-bot

nodejs-github-bot commented Sep 4, 2024•
edited by jakecastelli
Loading

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/61905/ 💛

@aduh95aduh95 added the commit-queue Add this label to land a pull request using GitHub Actions. label Sep 6, 2024
@nodejs-github-botnodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Sep 6, 2024
@nodejs-github-bot
nodejs-github-bot merged commit 973144b into nodejs:mainSep 6, 2024
@nodejs-github-bot

nodejs-github-bot commented Sep 6, 2024

Copy link
Copy Markdown
Collaborator

Landed in 973144b

aduh95 pushed a commit that referenced this pull request Sep 12, 2024
@jazelly@jakecastelli@aduh95
lib: convert signals to array before validation
fc78ced
Co-authored-by: Jake Yuesong Li <jake.yuesong@gmail.com>
PR-URL: #54714Fixes: #54674
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Matthew Aitken <maitken033380023@gmail.com>
Reviewed-By: Ethan Arrowood <ethan@arrowood.dev>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
@RafaelGSSRafaelGSS mentioned this pull request Sep 16, 2024
Merged
@jazelly
jazelly deleted the fix-abort-any branch November 25, 2024 22:07
This was referenced Apr 16, 2025
Merged
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@panvapanvapanva left review comments
@jakecastellijakecastellijakecastelli left review comments
@KhafraDevKhafraDevKhafraDev approved these changes
@mcollinamcollinamcollina approved these changes
@benjamingrbenjamingrbenjamingr approved these changes
@aduh95aduh95aduh95 approved these changes
@Ethan-ArrowoodEthan-ArrowoodEthan-Arrowood approved these changes
+2 more reviewers
@aymen94aymen94aymen94 approved these changes
@mertcanaltinmertcanaltinmertcanaltin approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.cryptoIssues and PRs related to the crypto subsystem.needs-ciPRs that need a full CI run.web-standardsIssues and PRs related to Web APIs

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

AbortSignal.any does not work on all sequences

12 participants

@jazelly@nodejs-github-bot@KhafraDev@jakecastelli@mcollina@panva@benjamingr@aymen94@aduh95@Ethan-Arrowood@mertcanaltin@targos