Skip to content

fs: translate error code properly in cpSync - #54906

Merged
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
jazelly:translate-fs-errors
Sep 16, 2024
Merged

fs: translate error code properly in cpSync#54906
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
jazelly:translate-fs-errors

Conversation

@jazelly

@jazellyjazelly commented Sep 12, 2024

Copy link
Copy Markdown
Member

UV error code needs to be negative integer so it can be mapped correctly. The filesystem error are positive integer, so we need to handle it before throwing.

Refs: #53614 (comment)

@nodejs-github-botnodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. fs Issues and PRs related to the fs subsystem / file system. needs-ci PRs that need a full CI run. labels Sep 12, 2024
@jakecastellijakecastelli added request-ci Add this label to start a Jenkins CI on a PR. and removed request-ci Add this label to start a Jenkins CI on a PR. labels Sep 12, 2024
@jakecastellijakecastelli added the request-ci Add this label to start a Jenkins CI on a PR. label Sep 12, 2024
@github-actionsgithub-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Sep 12, 2024
@nodejs-github-bot

nodejs-github-bot commented Sep 12, 2024

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/62355/

@anonrig

anonrig commented Sep 12, 2024

Copy link
Copy Markdown
Member

Nice. Thank you!

@anonriganonrig added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Sep 12, 2024
@codecov

codecovBot commented Sep 12, 2024•
edited
Loading

Copy link
Copy Markdown

Codecov Report

Attention: Patch coverage is 75.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 88.05%. Comparing base (9db6327) to head (090dce2).
Report is 142 commits behind head on main.

Files with missing linesPatch %Lines
src/node_file.cc75.00%0 Missing and 1 partial ⚠️
Additional details and impacted files
@@ Coverage Diff @@## main #54906 +/- ##
==========================================
- Coverage 88.05% 88.05% -0.01% 
==========================================
Files 651 651 Lines 183405 183412 +7 Branches 35822 35825 +3 ==========================================
- Hits 161499 161497 -2 - Misses 15159 15160 +1 - Partials 6747 6755 +8
Files with missing linesCoverage Δ
src/node_file.cc77.09% <75.00%> (+0.11%)⬆️

... and 31 files with indirect coverage changes

@jazelly
jazellyforce-pushed the translate-fs-errors branch 2 times, most recently from c94e771 to b49dafbCompareSeptember 13, 2024 06:57
lpinca
lpinca approved these changes Sep 13, 2024
View reviewed changes
Comment threadtest/parallel/test-fs-cp.mjs Outdated
Comment threadtest/parallel/test-fs-cp.mjs Outdated
@jazelly@jakecastelli
fs: translate error code properly in cpSync
090dce2
UV error code needs to be negative integer so it can be mapped
correctly. The filesystem error are positive integer, so we need to
handle it before throwing.
Co-authored-by: Jake Yuesong Li <jake.yuesong@gmail.com>
@lpincalpinca added the request-ci Add this label to start a Jenkins CI on a PR. label Sep 13, 2024
@github-actionsgithub-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Sep 13, 2024
@nodejs-github-bot

nodejs-github-bot commented Sep 13, 2024•
edited by jakecastelli
Loading

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/62388/ 💛

@jakecastellijakecastelli added the commit-queue Add this label to land a pull request using GitHub Actions. label Sep 16, 2024
@nodejs-github-botnodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Sep 16, 2024
@nodejs-github-bot
nodejs-github-bot merged commit c1afd2c into nodejs:mainSep 16, 2024
@nodejs-github-bot

nodejs-github-bot commented Sep 16, 2024

Copy link
Copy Markdown
Collaborator

Landed in c1afd2c

@RafaelGSSRafaelGSS mentioned this pull request Sep 16, 2024
Merged
RafaelGSS pushed a commit that referenced this pull request Sep 16, 2024
@jazelly@jakecastelli@RafaelGSS
fs: translate error code properly in cpSync
8997e69
UV error code needs to be negative integer so it can be mapped
correctly. The filesystem error are positive integer, so we need to
handle it before throwing.
Co-authored-by: Jake Yuesong Li <jake.yuesong@gmail.com>
PR-URL: #54906
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
RafaelGSS pushed a commit that referenced this pull request Sep 17, 2024
@jazelly@jakecastelli@RafaelGSS
fs: translate error code properly in cpSync
beb4925
UV error code needs to be negative integer so it can be mapped
correctly. The filesystem error are positive integer, so we need to
handle it before throwing.
Co-authored-by: Jake Yuesong Li <jake.yuesong@gmail.com>
PR-URL: #54906
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
RafaelGSS pushed a commit that referenced this pull request Sep 17, 2024
@jazelly@jakecastelli@RafaelGSS
fs: translate error code properly in cpSync
93116dd
UV error code needs to be negative integer so it can be mapped
correctly. The filesystem error are positive integer, so we need to
handle it before throwing.
Co-authored-by: Jake Yuesong Li <jake.yuesong@gmail.com>
PR-URL: #54906
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
@jazelly
jazelly deleted the translate-fs-errors branch November 25, 2024 22:07
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lpincalpincalpinca approved these changes
@anonriganonriganonrig approved these changes
@richardlaurichardlaurichardlau approved these changes

Assignees

No one assigned

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.c++Issues and PRs that require attention from people who are familiar with C++.fsIssues and PRs related to the fs subsystem / file system.needs-ciPRs that need a full CI run.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@jazelly@nodejs-github-bot@anonrig@lpinca@richardlau@targos@jakecastelli