Skip to content

test: merge knownGlobals in common - #54915

Closed
avivkeller wants to merge 1 commit into
nodejs:mainfrom
avivkeller:patch-134
Closed

test: merge knownGlobals in common#54915
avivkeller wants to merge 1 commit into
nodejs:mainfrom
avivkeller:patch-134

Conversation

@avivkeller

Copy link
Copy Markdown
Member

The knownGlobals array can be simplified, as shown in this PR

@nodejs-github-botnodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Sep 12, 2024
@codecov

codecovBot commented Sep 13, 2024

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.06%. Comparing base (92ca0b7) to head (4799bf6).
Report is 148 commits behind head on main.

Additional details and impacted files
@@ Coverage Diff @@## main #54915 +/- ##
==========================================
- Coverage 88.06% 88.06% -0.01% 
==========================================
Files 651 651 Lines 183409 183409 Branches 35822 35829 +7 ==========================================
- Hits 161519 161512 -7 - Misses 15148 15157 +9 + Partials 6742 6740 -2 

see 22 files with indirect coverage changes

@aduh95

Copy link
Copy Markdown
Contributor

I still think #42056 would be a better approach

@avivkeller

Copy link
Copy Markdown
MemberAuthor

Closing in favor

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs-ciPRs that need a full CI run.testIssues and PRs related to the tests.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@avivkeller@aduh95@nodejs-github-bot