Skip to content

doc: remove outdated sentence - #54963

Closed
lpinca wants to merge 1 commit into
nodejs:mainfrom
lpinca:fix/issue-54961
Closed

doc: remove outdated sentence#54963
lpinca wants to merge 1 commit into
nodejs:mainfrom
lpinca:fix/issue-54961

Conversation

@lpinca

Copy link
Copy Markdown
Member

The 'IPv4' and 'IPv6' values are no longer supported.

Fixes: #54961

@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/net

@nodejs-github-botnodejs-github-bot added dns Issues and PRs related to the dns subsystem. doc Issues and PRs related to the documentations. labels Sep 16, 2024
Comment threaddoc/api/dns.md Outdated
The `'IPv4'` and `'IPv6'` values are no longer supported.
Fixes: nodejs#54961

@aduh95aduh95 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add an entry in the YAML list?

@lpinca

Copy link
Copy Markdown
MemberAuthor

The current documentation is correct

$ ./node
Welcome to Node.js v23.0.0-pre.
Type ".help" for more information.
> dns.lookup('example.com', { family: 'IPv4' }, function (err, result) { console.log(result) })
GetAddrInfoReqWrap {
callback: [Function (anonymous)],
family: 4,
hostname: 'example.com',
oncomplete: [Function: onlookup]
}
> 93.184.215.14

The 'IPv4' and 'IPv6' values are not supported in the promise returning variant, but that is also correctly documented.

@lpincalpinca closed this Sep 16, 2024
@lpinca
lpinca deleted the fix/issue-54961 branch September 16, 2024 12:42
@avivkeller

Copy link
Copy Markdown
Member

However the deprecation has reached End-Of-Life per #41431, so maybe that behavior should be changed?

@aduh95

Copy link
Copy Markdown
Contributor

See #43054. It might make sense to update deprecations.md to clarify dns.lookup is no longer in scope.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dnsIssues and PRs related to the dns subsystem.docIssues and PRs related to the documentations.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

dns.lookup options..family throw errors when using 'IPv4'

4 participants

@lpinca@nodejs-github-bot@avivkeller@aduh95