Skip to content

test,crypto: update WebCryptoAPI WPT - #55029

Merged
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
panva:bump-webcrypto
Sep 22, 2024
Merged

test,crypto: update WebCryptoAPI WPT#55029
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
panva:bump-webcrypto

Conversation

@panva

Copy link
Copy Markdown
Member

Just git node wpt WebCryptoAPI.

@panvapanva added crypto Issues and PRs related to the crypto subsystem. test Issues and PRs related to the tests. webcrypto web-standards Issues and PRs related to Web APIs labels Sep 20, 2024
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/web-standards

@nodejs-github-botnodejs-github-bot added the needs-ci PRs that need a full CI run. label Sep 20, 2024
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

@codecov

codecovBot commented Sep 20, 2024

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.03%. Comparing base (d5c29ba) to head (0816051).
Report is 512 commits behind head on main.

Additional details and impacted files
@@ Coverage Diff @@## main #55029 +/- ##
==========================================
- Coverage 88.06% 88.03% -0.04% 
==========================================
Files 652 652 Lines 183546 183797 +251 Branches 35860 35861 +1 ==========================================
+ Hits 161648 161801 +153 - Misses 15149 15243 +94 - Partials 6749 6753 +4 

see 50 files with indirect coverage changes

@lpincalpinca added the request-ci Add this label to start a Jenkins CI on a PR. label Sep 21, 2024
@github-actionsgithub-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Sep 21, 2024
@nodejs-github-bot

nodejs-github-bot commented Sep 21, 2024

Copy link
Copy Markdown
Collaborator

@panvapanva added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Sep 21, 2024
@panvapanva added the commit-queue Add this label to land a pull request using GitHub Actions. label Sep 21, 2024
@nodejs-github-botnodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Sep 22, 2024
@nodejs-github-bot
nodejs-github-bot merged commit 0e187e4 into nodejs:mainSep 22, 2024
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

Landed in 0e187e4

targos pushed a commit that referenced this pull request Oct 4, 2024
PR-URL: #55029
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Jake Yuesong Li <jake.yuesong@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@aduh95aduh95 mentioned this pull request Oct 9, 2024
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.cryptoIssues and PRs related to the crypto subsystem.needs-ciPRs that need a full CI run.testIssues and PRs related to the tests.web-standardsIssues and PRs related to Web APIswebcrypto

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants

@panva@nodejs-github-bot@jasnell@lpinca@jakecastelli@marco-ippolito