Skip to content

test_runner: avoid spread operator on arrays - #55143

Merged
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
aduh95:no-spread-on-arrays
Sep 29, 2024
Merged

test_runner: avoid spread operator on arrays#55143
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
aduh95:no-spread-on-arrays

Conversation

@aduh95

@aduh95aduh95 commented Sep 27, 2024

Copy link
Copy Markdown
Contributor

No description provided.

@aduh95
aduh95 requested a review from cjihrigSeptember 27, 2024 15:16
@nodejs-github-bot

nodejs-github-bot commented Sep 27, 2024

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/test_runner

@nodejs-github-botnodejs-github-bot added needs-ci PRs that need a full CI run. test_runner Issues and PRs related to the test runner subsystem. labels Sep 27, 2024
@codecov

codecovBot commented Sep 27, 2024•
edited
Loading

Copy link
Copy Markdown

Codecov Report

Attention: Patch coverage is 66.66667% with 2 lines in your changes missing coverage. Please review.

Project coverage is 88.24%. Comparing base (fbc6fcb) to head (979af26).
Report is 358 commits behind head on main.

Files with missing linesPatch %Lines
lib/internal/test_runner/runner.js33.33%2 Missing ⚠️
Additional details and impacted files
@@ Coverage Diff @@## main #55143 +/- ##
=======================================
Coverage 88.23% 88.24% =======================================
Files 651 651 Lines 183914 183901 -13 Branches 35865 35862 -3 =======================================
+ Hits 162279 162282 +3 + Misses 14910 14904 -6 + Partials 6725 6715 -10
Files with missing linesCoverage Δ
lib/internal/test_runner/test.js96.94% <100.00%> (+<0.01%)⬆️
lib/internal/test_runner/runner.js86.75% <33.33%> (-0.10%)⬇️

... and 20 files with indirect coverage changes

mcollina
mcollina approved these changes Sep 28, 2024
View reviewed changes

@mcollinamcollina left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@aduh95aduh95 added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels Sep 28, 2024
@github-actionsgithub-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Sep 28, 2024
@nodejs-github-bot

nodejs-github-bot commented Sep 28, 2024

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/62819/

@aduh95aduh95 added the commit-queue Add this label to land a pull request using GitHub Actions. label Sep 28, 2024
@nodejs-github-botnodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Sep 29, 2024
@nodejs-github-bot
nodejs-github-bot merged commit 103b843 into nodejs:mainSep 29, 2024
@nodejs-github-bot

nodejs-github-bot commented Sep 29, 2024

Copy link
Copy Markdown
Collaborator

Landed in 103b843

@aduh95
aduh95 deleted the no-spread-on-arrays branch September 29, 2024 17:58
targos pushed a commit that referenced this pull request Oct 4, 2024
@aduh95@targos
test_runner: avoid spread operator on arrays
ab98692
PR-URL: #55143
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
targos pushed a commit that referenced this pull request Oct 4, 2024
@aduh95@targos
test_runner: avoid spread operator on arrays
c308862
PR-URL: #55143
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@aduh95aduh95 mentioned this pull request Oct 9, 2024
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mcollinamcollinamcollina approved these changes
@jasnelljasnelljasnell approved these changes
@cjihrigcjihrigcjihrig approved these changes

Assignees

No one assigned

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.needs-ciPRs that need a full CI run.test_runnerIssues and PRs related to the test runner subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@aduh95@nodejs-github-bot@mcollina@jasnell@cjihrig@marco-ippolito