Skip to content

build: drop support for python 3.8 - #55239

Merged
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
avivkeller:python39
Jan 24, 2025
Merged

build: drop support for python 3.8#55239
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
avivkeller:python39

Conversation

@avivkeller

@avivkelleravivkeller commented Oct 2, 2024•
edited
Loading

Copy link
Copy Markdown
Member

After next Monday acceptable versions should be py39, py310, py311, py312, py313.

Originally posted by @cclauss in #54358 (comment)

@nodejs-github-botnodejs-github-bot added build Issues and PRs related to build files or the CI. needs-ci PRs that need a full CI run. labels Oct 2, 2024
@avivkelleravivkeller added the python PRs and issues that require attention from people who are familiar with Python. label Oct 2, 2024
@cclauss

cclauss commented Oct 2, 2024•
edited
Loading

Copy link
Copy Markdown
Contributor

Let's wait for Python 3.13's official release before we merge this.

SEPARATE ISSUE: How does our dependabot config not flag that we are doing some testing on Node.js 12?

@avivkelleravivkeller added the blocked PRs that are blocked by other issues or PRs. label Oct 2, 2024
@richardlau

This comment was marked as off-topic.

Sign in to view
@avivkeller

This comment was marked as off-topic.

Sign in to view
@avivkelleravivkeller removed the blocked PRs that are blocked by other issues or PRs. label Oct 6, 2024
@avivkeller

avivkeller commented Oct 6, 2024

Copy link
Copy Markdown
MemberAuthor

Happy Sunday :-). Monday is just a few hours away, so I've unblocked this PR, when you get a chance, a review would be appreciated

@avivkelleravivkeller added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels Oct 6, 2024
@github-actionsgithub-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Oct 6, 2024
@nodejs-github-bot

nodejs-github-bot commented Oct 6, 2024

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/62952/

@cclauss

cclauss commented Oct 7, 2024•
edited
Loading

Copy link
Copy Markdown
Contributor

https://www.python.org/downloads/release/python-3130/
https://devguide.python.org/versions/

@aduh95

aduh95 commented Oct 9, 2024

Copy link
Copy Markdown
Contributor

@nodejs/build there are at least 3 jobs which are using Python 3.8 (smartos, rhel8, ubi81_sharedlibs_openssl111fips_x64) and failing with this PR, what would be the way forward?

@richardlau

richardlau commented Oct 9, 2024•
edited by cclauss
Loading

Copy link
Copy Markdown
Member

@nodejs/build there are at least 3 jobs which are using Python 3.8 (smartos, rhel8, ubi81_sharedlibs_openssl111fips_x64) and failing with this PR, what would be the way forward?

I can get the arm64 RHEL 8 and ubi81_sharedlibs_openssl111fips_x64 updated to use later Python versions.
The plan is to migrate/update the SmartOS machines -- being tracked in nodejs/build#3731.

This was referenced Oct 9, 2024
Closed
Merged
@nodejs-github-bot

nodejs-github-bot commented Oct 9, 2024

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/63011/

richardlau added a commit to nodejs/build that referenced this pull request Oct 11, 2024
@richardlau
ansible: update Python on ubi8/rhel8 containers (#3930)
cb672f0
Update the version of Python used in the UBI 8/RHEL 8 container
images from Python 3.8 to 3.12.
Refs: nodejs/node#55239 (comment)
@avivkeller

avivkeller commented Oct 12, 2024

Copy link
Copy Markdown
MemberAuthor

UBI/RHEL 8 has been updated, now we just need to wait for SmartOS

@avivkelleravivkeller added the blocked PRs that are blocked by other issues or PRs. label Oct 12, 2024
@avivkeller

avivkeller commented Oct 30, 2024

Copy link
Copy Markdown
MemberAuthor

Is there any ETA on upping the SmartOS python?

@aduh95aduh95 added the request-ci Add this label to start a Jenkins CI on a PR. label Jan 23, 2025
@github-actionsgithub-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jan 23, 2025
@nodejs-github-bot

nodejs-github-bot commented Jan 23, 2025

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/64658/

@nodejs-github-bot

nodejs-github-bot commented Jan 23, 2025

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/64673/

@cclauss

cclauss commented Jan 24, 2025•
edited
Loading

Copy link
Copy Markdown
Contributor

I do not see a need to wait for SmartOS to catch up. Their Makefile builds with Node.js v0 and Python 2.7… How can a secure OS be build on top of insecure foundations.

@aduh95aduh95 added commit-queue Add this label to land a pull request using GitHub Actions. dont-land-on-v22.x PRs that should not land on the v22.x-staging branch and should not be released in v22.x. dont-land-on-v23.x and removed blocked PRs that are blocked by other issues or PRs. labels Jan 24, 2025
@aduh95

aduh95 commented Jan 24, 2025•
edited
Loading

Copy link
Copy Markdown
Contributor

@nodejs/releasers I've added dont-land-on-v22.xPRs that should not land on the v22.x-staging branch and should not be released in v22.x. and https://github.com/nodejs/node/labels/dont-land-on-v23%2Ex, I don't know if that's correct but given that we're somewhat close to 24.0.0 release it seems safer to not attempt a backport.

@nodejs-github-botnodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jan 24, 2025
@nodejs-github-bot
nodejs-github-bot merged commit e55b02b into nodejs:mainJan 24, 2025
@nodejs-github-bot

nodejs-github-bot commented Jan 24, 2025

Copy link
Copy Markdown
Collaborator

Landed in e55b02b

@RafaelGSSRafaelGSS mentioned this pull request May 1, 2025
Merged
@shipujinshipujin mentioned this pull request Jul 30, 2025
Closed
@MikeMcC399MikeMcC399 mentioned this pull request Dec 2, 2025
Closed
@MikeMcC399MikeMcC399 mentioned this pull request Dec 26, 2025
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cclausscclausscclauss approved these changes

Assignees

No one assigned

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.buildIssues and PRs related to build files or the CI.dont-land-on-v22.xPRs that should not land on the v22.x-staging branch and should not be released in v22.x.needs-ciPRs that need a full CI run.pythonPRs and issues that require attention from people who are familiar with Python.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@avivkeller@cclauss@richardlau@nodejs-github-bot@aduh95