Skip to content

build: try disabling sccache - #55259

Closed
targos wants to merge 1 commit into
nodejs:mainfrom
targos:test-disable-sccache
Closed

build: try disabling sccache#55259
targos wants to merge 1 commit into
nodejs:mainfrom
targos:test-disable-sccache

Conversation

@targos

Copy link
Copy Markdown
Member

No description provided.

@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/actions

@nodejs-github-botnodejs-github-bot added the meta Issues and PRs related to the general management of the project. label Oct 4, 2024
@codecov

codecovBot commented Oct 4, 2024

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.88%. Comparing base (8de2695) to head (db72d92).
Report is 3 commits behind head on main.

Additional details and impacted files
@@ Coverage Diff @@## main #55259 +/- ##
==========================================
- Coverage 88.41% 87.88% -0.53% 
==========================================
Files 652 652 Lines 186576 186594 +18 Branches 36049 35752 -297 ==========================================
- Hits 164960 163997 -963 - Misses 14889 15817 +928 - Partials 6727 6780 +53 

see 97 files with indirect coverage changes

@targos

targos commented Oct 4, 2024

Copy link
Copy Markdown
MemberAuthor

Coverage Linux / coverage-linux (pull_request) Successful in 150m

Where the Build step took 1h50m

Vs for example #55243

Coverage Linux / coverage-linux (pull_request) Successful in 82m

Where the Build step took 43m

@aduh95 FYI

@aduh95

Copy link
Copy Markdown
Contributor

Interesting, I guess the summary feature is broken then, https://github.com/nodejs/node/actions/runs/11148492160?pr=55243 shows 0% of cache hit.

@targostargos closed this Oct 4, 2024
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

metaIssues and PRs related to the general management of the project.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@targos@nodejs-github-bot@aduh95