Uh oh!
There was an error while loading. Please reload this page.
test: remove broken debugger scenarios - #5532
Closed
Trott wants to merge 1 commit into
Closed
Conversation
`test-debug-break-on-uncaught` was hanging on the domain and parse error scenarios. These tests are not run in CI and may have been broken for a very long time. Refs: nodejs#3156 Refs: nodejs@c16963b9
Trott
commented
Mar 3, 2016
MemberAuthor
One more time, this time hopefully without me putting typos in the CI parameters form: |
Trott
commented
Mar 3, 2016
MemberAuthor
Raspberry Pi failure is surely unrelated... ...but that won't stop me from running CI again: https://ci.nodejs.org/job/node-test-pull-request/1839/ |
Trott
commented
Mar 4, 2016
MemberAuthor
CI is green. (Which I guess is not surprising as the only thing that happens to this code on CI is that it gets linted.) Not sure who would be comfy giving this an LGTM or saying "sorry, no", but let's try the short list of people that:
|
Trott
commented
Mar 6, 2016
MemberAuthor
/cc @nodejs/testing |
bnoordhuis
commented
Mar 6, 2016
Member
For background, the tests were moved out of test/simple because they're very flaky (inherently so.) |
rvagg
commented
Mar 7, 2016
Member
lgtm, cut cut cut |
jasnell
commented
Mar 7, 2016
Member
LGTM |
jasnell pushed a commit
that referenced
this pull request
Mar 7, 2016
`test-debug-break-on-uncaught` was hanging on the domain and parse error scenarios. These tests are not run in CI and may have been broken for a very long time. Refs: #3156 Refs: c16963b9 PR-URL: #5532 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rod Vagg <r@va.gg>
jasnell
commented
Mar 7, 2016
Member
Landed in eb3f04d |
Merged
Fishrock123 pushed a commit
that referenced
this pull request
Mar 8, 2016
`test-debug-break-on-uncaught` was hanging on the domain and parse error scenarios. These tests are not run in CI and may have been broken for a very long time. Refs: #3156 Refs: c16963b9 PR-URL: #5532 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rod Vagg <r@va.gg>
Fishrock123 pushed a commit
that referenced
this pull request
Mar 8, 2016
`test-debug-break-on-uncaught` was hanging on the domain and parse error scenarios. These tests are not run in CI and may have been broken for a very long time. Refs: #3156 Refs: c16963b9 PR-URL: #5532 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rod Vagg <r@va.gg>
MylesBorins pushed a commit
that referenced
this pull request
Mar 17, 2016
`test-debug-break-on-uncaught` was hanging on the domain and parse error scenarios. These tests are not run in CI and may have been broken for a very long time. Refs: #3156 Refs: c16963b9 PR-URL: #5532 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rod Vagg <r@va.gg>
MylesBorins pushed a commit
that referenced
this pull request
Mar 21, 2016
`test-debug-break-on-uncaught` was hanging on the domain and parse error scenarios. These tests are not run in CI and may have been broken for a very long time. Refs: #3156 Refs: c16963b9 PR-URL: #5532 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rod Vagg <r@va.gg>
MylesBorins pushed a commit
that referenced
this pull request
Mar 21, 2016
`test-debug-break-on-uncaught` was hanging on the domain and parse error scenarios. These tests are not run in CI and may have been broken for a very long time. Refs: #3156 Refs: c16963b9 PR-URL: #5532 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rod Vagg <r@va.gg>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
make -j8 test(UNIX) orvcbuild test nosign(Windows) pass withthis change (including linting)?
test-debug-break-on-uncaughtwas hanging on the domain and parse errorscenarios. These tests are not run in CI and may have been broken
for a very long time.
Refs: #3156
Refs: c16963b9
It's not clear to me that the two test scenarios removed here are valid. (/cc @bnoordhuis maybe? See c16963b9 for original commit creating the test)
If simple removal is valid, then this test can be subsequently moved to
parallelso it can be run in CI on a regular basis.